In D24324#630061, @0mp wrote:

In D24324#549920, @andrew_tao173.riddles.org.uk wrote:

Discussion point: this implementation converts the variable name to upper case for consistency with the way that port option_VARS works. But there are some cases where one might want to set a mixed-case name (such as CFLAGS.arch), so maybe it shouldn't do that and just use the case as written?

I'd say there is no point in supporting all-lowercase variable names (e.g., disable_make_jobs) instead of just the actual names (e.g., DISABLE_MAKE_JOBS). I must say that I'm a bit confused why option_VARS is supposedly supporting such a syntactic sugar.

This is a clever approach! If I'm reading it correctly, this should also fix the case of unnecessary (i.e. test/bench) modules being dragged in and not used in the final build.