Page MenuHomeFreeBSD
Differential D33352

libthr: Use <machine/tls.h> for most MD TLS details.
ClosedPublic
Actions

Authored by jhb on Dec 8 2021, 9:52 PM.
Tags
None
Referenced Files
F137989409: D33352.id99794.diff
Thu, Nov 27, 10:36 PM
Unknown Object (File)
Sun, Nov 23, 7:23 AM
Unknown Object (File)
Fri, Nov 14, 12:02 PM
Unknown Object (File)
Thu, Nov 13, 8:42 AM
Unknown Object (File)
Thu, Oct 30, 5:52 AM
Unknown Object (File)
Oct 27 2025, 1:34 PM
Unknown Object (File)
Oct 26 2025, 2:54 PM
Unknown Object (File)
Oct 7 2025, 11:24 PM
View All 96 Files
Subscribers
andrew
imp

Details

Reviewers
emaste
jrtc27
kib
Commits
rG34e70df37ae7: libthr: Use <machine/tls.h> for most MD TLS details.
rG75395023ff1e: libthr: Use <machine/tls.h> for most MD TLS details.
Summary

Note that on amd64 this effectively removes the unused tcb_spare field
from the end of struct tcb since the definition of struct tcb in
<x86/tls.h> does not include that field.

Sponsored by: The University of Cambridge, Google Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43252
Build 40140: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 8 2021, 9:52 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptDec 8 2021, 9:52 PM
jhb requested review of this revision.Dec 8 2021, 9:52 PM
Harbormaster completed remote builds in B43252: Diff 99740.Dec 8 2021, 9:52 PM
jhb added a parent revision: D33351: Add <machine/tls.h> header to hold MD constants and helpers for TLS..Dec 8 2021, 9:52 PM
jhb added a child revision: D33353: TLS: Use <machine/tls.h> for libc and rtld..
jhb edited the summary of this revision. (Show Details)Dec 9 2021, 12:59 AM
kib accepted this revision.Dec 9 2021, 1:01 AM
kib added inline comments.
lib/libthr/arch/mips/include/pthread_md.h
46

Is this check practically needed?

This revision is now accepted and ready to land.Dec 9 2021, 1:01 AM
jhb added inline comments.Dec 9 2021, 1:09 AM
lib/libthr/arch/mips/include/pthread_md.h
46

That's a good question. x86 does not check this and assumes that a TCB is always present.

Closed by commit rG75395023ff1e: libthr: Use <machine/tls.h> for most MD TLS details. (authored by jhb). · Explain WhyDec 9 2021, 9:25 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG75395023ff1e: libthr: Use <machine/tls.h> for most MD TLS details..
jhb added a commit: rG34e70df37ae7: libthr: Use <machine/tls.h> for most MD TLS details..Apr 29 2022, 8:56 PM

Revision Contents
Changeset List

PathSize
lib/
libthr/
arch/
aarch64/
include/
31 lines
amd64/
include/
56 lines
arm/
include/
31 lines
i386/
include/
58 lines
mips/
include/
80 lines
powerpc/
include/
43 lines
riscv/
include/
32 lines

Diff 99740

View Options

lib/libthr/arch/aarch64/include/pthread_md.h

Loading...
View Options

lib/libthr/arch/amd64/include/pthread_md.h

Loading...
View Options

lib/libthr/arch/arm/include/pthread_md.h

Loading...
View Options

lib/libthr/arch/i386/include/pthread_md.h

Loading...
View Options

lib/libthr/arch/mips/include/pthread_md.h

Loading...
View Options

lib/libthr/arch/powerpc/include/pthread_md.h

Loading...
View Options

lib/libthr/arch/riscv/include/pthread_md.h

Loading...