Details

Reviewers

markj
trasz
mhorne

Group Reviewers

NetApp

Commits

rGace38c58fbc2: savecore: emit information about saved cores under verbose

Summary

Declare how many cores we saved, and where we saved them to. Drop a
comment about emitting little information; it's obvious from the block
in question that we emit nothing without verbose.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #65

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43224
Build 40112: arc lint + arc unit

Event Timeline

kevans created this revision.Aug 3 2021, 4:10 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2021, 4:10 AM

kevans requested review of this revision.Aug 3 2021, 4:10 AM

Harbormaster completed remote builds in B40820: Diff 93159.Aug 3 2021, 4:10 AM

markj added inline comments.Aug 3 2021, 1:11 PM

sbin/savecore/savecore.c
1318–1319	This comment should probably be deleted.
1322	savecore calls openlog() with LOG_PERROR, so messages logged with logmsg() go to standard error. So we are effectively printing the same message twice when -v is specified.
1336	We consistently omit a period in other messages.

kevans added inline comments.Aug 3 2021, 2:30 PM

sbin/savecore/savecore.c
1322	I was going to collapse them down into just one, but looking back we intentionally killed off messages in the default path back in 2015. Perhaps this change should just be dropped instead...

markj added inline comments.Aug 3 2021, 3:10 PM

sbin/savecore/savecore.c
1322	One can always set `savecore_flags=-v` in rc.conf if desired...

Drop comment, just add message about \# cores saved and where on verbose runs.

Commit message update incoming.

Harbormaster completed remote builds in B43209: Diff 99633.Dec 7 2021, 4:05 AM

Correct diff; drop the period.

Harbormaster completed remote builds in B43210: Diff 99634.Dec 7 2021, 4:06 AM

kevans retitled this revision from savecore: be a little more verbose to savecore: emit information about saved cores under verbose.Dec 7 2021, 4:07 AM

kevans edited the summary of this revision. (Show Details)

kevans added a reviewer: mhorne.

markj added inline comments.Dec 7 2021, 2:50 PM