savecore: emit information about saved cores under verbose

[kevans]

Summary

Declare how many cores we saved, and where we saved them to. Drop a
comment about emitting little information; it's obvious from the block
in question that we emit nothing without verbose.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #65

[markj]

sbin/savecore/savecore.c

1318–1319

This comment should probably be deleted.

1322

savecore calls openlog() with LOG_PERROR, so messages logged with logmsg() go to standard error. So we are effectively printing the same message twice when -v is specified.

1336

We consistently omit a period in other messages.

[kevans]

sbin/savecore/savecore.c

1322

I was going to collapse them down into just one, but looking back we intentionally killed off messages in the default path back in 2015. Perhaps this change should just be dropped instead...

[markj]

sbin/savecore/savecore.c

1322

One can always set savecore_flags=-v in rc.conf if desired...

[kevans]

Drop comment, just add message about \# cores saved and where on verbose runs.

Commit message update incoming.

[kevans]

Correct diff; drop the period.

[markj]

sbin/savecore/savecore.c

1336

Should this be using logmsg()?

[kevans]

Use logmsg(), level LOG_NOTICE