pfsync: check IFF_DRV_RUNNING in the correct field
ClosedPublic
Actions

Authored by kp on Dec 3 2021, 9:48 AM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGef6a011da523: pfsync: check IFF_DRV_RUNNING in the correct field
rG2c1d3e522bed: pfsync: check IFF_DRV_RUNNING in the correct field
rG7b02a551f78e: pfsync: check IFF_DRV_RUNNING in the correct field

Summary

This flag is stored in if_drv_flags, not if_flags.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43116
Build 40004: arc lint + arc unit

Event Timeline

kp created this revision.Dec 3 2021, 9:48 AM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptDec 3 2021, 9:48 AM

kp requested review of this revision.Dec 3 2021, 9:48 AM

kp added a parent revision: D33240: pfsync: NULL check sc before using it.

Harbormaster completed remote builds in B43116: Diff 99388.Dec 3 2021, 9:48 AM

kp added a child revision: D33242: pfsync: fix defer timeout.Dec 3 2021, 9:48 AM

glebius accepted this revision.Dec 3 2021, 4:47 PM

This revision is now accepted and ready to land.Dec 3 2021, 4:47 PM

Closed by commit rG7b02a551f78e: pfsync: check IFF_DRV_RUNNING in the correct field (authored by kp). · Explain WhyDec 6 2021, 12:25 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG7b02a551f78e: pfsync: check IFF_DRV_RUNNING in the correct field.

kp added a commit: rG2c1d3e522bed: pfsync: check IFF_DRV_RUNNING in the correct field.Dec 13 2021, 1:51 PM

kp added a commit: rGef6a011da523: pfsync: check IFF_DRV_RUNNING in the correct field.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

if_pfsync.c

2 lines

Diff 99388

View Options

sys/netpfil/pf/if_pfsync.c

pfsync: check IFF_DRV_RUNNING in the correct fieldClosedPublicActions