Fix bracketing in the arm64 minidump code
ClosedPublic
Actions

Authored by andrew on Nov 23 2021, 6:32 PM.

Details

Reviewers

mhorne
manu
imp

Group Reviewers

arm64

Commits

rGb2db0024aef9: Fix bracketing in the arm64 minidump code
rG3ff041945054: Fix bracketing in the arm64 minidump code

Summary

When building with gcc10 it suggests the parentheses are wrong. Set them
to be the calculated physical address or'd with page table attributes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Nov 23 2021, 6:32 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 23 2021, 6:32 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Nov 23 2021, 6:32 PM

Harbormaster completed remote builds in B42940: Diff 98886.Nov 23 2021, 6:32 PM

mhorne accepted this revision.Nov 23 2021, 6:51 PM

This revision is now accepted and ready to land.Nov 23 2021, 6:51 PM

imp accepted this revision.Nov 23 2021, 8:51 PM

Closed by commit rG3ff041945054: Fix bracketing in the arm64 minidump code (authored by andrew). · Explain WhyNov 24 2021, 3:38 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG3ff041945054: Fix bracketing in the arm64 minidump code.

andrew added a commit: rGb2db0024aef9: Fix bracketing in the arm64 minidump code.Dec 20 2021, 2:02 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

minidump_machdep.c

6 lines

Diff 98954

View Options

sys/arm64/arm64/minidump_machdep.c

Fix bracketing in the arm64 minidump codeClosedPublicActions