ipsec: fix a panic with INVARIANTS
ClosedPublic
Actions

Authored by rew on Nov 23 2021, 11:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 24, 7:44 PM

	Unknown Object (File)
	Fri, Jul 24, 12:47 PM

	Unknown Object (File)
	Wed, Jul 22, 9:41 AM

	Unknown Object (File)
	Mon, Jul 20, 9:29 AM

	Unknown Object (File)
	Sat, Jul 4, 2:41 PM

	Unknown Object (File)
	Sat, Jul 4, 1:00 PM

	Unknown Object (File)
	Sat, Jul 4, 1:00 PM

	Unknown Object (File)
	Sat, Jul 4, 11:36 AM

Subscribers

Details

Reviewers

ae
wma

Commits

rGfc21aafe5ff2: ipsec: fix a panic with INVARIANTS

Summary

When trying to add an SPD entry that already exists, a refcount
wraparound panic is encountered. This was caused from dropping a
reference on the wrong security policy.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42947
Build 39835: arc lint + arc unit

Event Timeline

rew created this revision.Nov 23 2021, 11:50 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptNov 23 2021, 11:50 PM

rew requested review of this revision.Nov 23 2021, 11:50 PM

Harbormaster completed remote builds in B42947: Diff 98929.Nov 23 2021, 11:50 PM

rew added a reviewer: ae.Nov 23 2021, 11:51 PM

ae added a reviewer: wma.Nov 24 2021, 10:45 AM

This looks like leftover from D31271.

wma accepted this revision.Nov 24 2021, 12:12 PM

This revision is now accepted and ready to land.Nov 24 2021, 12:12 PM

Closed by commit rGfc21aafe5ff2: ipsec: fix a panic with INVARIANTS (authored by rew). · Explain WhyDec 3 2021, 11:35 PM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rGfc21aafe5ff2: ipsec: fix a panic with INVARIANTS.

Revision Contents
Changeset List

Path

Size

sys/

netipsec/

key.c

2 lines

Diff 98929

View Options

ipsec: fix a panic with INVARIANTSClosedPublicActions