Differential D33087

pf: fix netpfil.common.dummynet:pf_nat test
ClosedPublic
Actions

Authored by kp on Nov 22 2021, 10:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 29, 3:21 PM

	Unknown Object (File)
	Sat, Mar 28, 11:01 PM

	Unknown Object (File)
	Sat, Mar 28, 4:31 PM

	Unknown Object (File)
	Fri, Mar 27, 12:41 PM

	Unknown Object (File)
	Fri, Mar 27, 5:47 AM

	Unknown Object (File)
	Thu, Mar 26, 4:36 PM

	Unknown Object (File)
	Sun, Mar 22, 8:01 AM

	Unknown Object (File)
	Sun, Mar 22, 4:48 AM

Subscribers

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG90c55481b273: pf: fix netpfil.common.dummynet:pf_nat test

Summary

This test failed if ipfw was loaded (as well as pf). pf used the same
tag as summynet to indicate a packet had already gone through dummynet.
However, ipfw removes this tag, so pf didn't realise the packet had
already gone through dummynet.

Introduce a separate flag, in the existing pf mtag rather than re-using
the ipfw tag. There were no free flag bits, but PF_TAG_FRAGCACHE is no
longer used so its bit can be re-purposed.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42924
Build 39812: arc lint + arc unit

Event Timeline

kp created this revision.Nov 22 2021, 10:39 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptNov 22 2021, 10:39 PM

kp requested review of this revision.Nov 22 2021, 10:39 PM

Harbormaster completed remote builds in B42924: Diff 98856.Nov 22 2021, 10:39 PM

kp added a parent revision: D33086: pf: align IPv6 dummynet handling with IPv4.Nov 22 2021, 10:39 PM

kp added a child revision: D33088: RELNOTES: mention 6rd support in if_stf.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2021, 5:49 PM

Closed by commit rG90c55481b273: pf: fix netpfil.common.dummynet:pf_nat test (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG90c55481b273: pf: fix netpfil.common.dummynet:pf_nat test.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

115 lines

2 lines

Diff 98856

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_mtag.h

Loading...