Page MenuHomeFreeBSD
Differential D32738

procfs: return right hardlink from /proc/curproc/file
ClosedPublic
Actions

Authored by kib on Oct 29 2021, 8:18 PM.
Tags
None
Referenced Files
F106114750: D32738.diff
Wed, Dec 25, 3:31 PM
Unknown Object (File)
Sun, Dec 15, 3:12 AM
Unknown Object (File)
Wed, Dec 11, 2:33 AM
Unknown Object (File)
Mon, Dec 9, 5:56 PM
Unknown Object (File)
Wed, Dec 4, 6:15 PM
Unknown Object (File)
Wed, Dec 4, 6:15 PM
Unknown Object (File)
Wed, Dec 4, 5:51 PM
Unknown Object (File)
Sep 28 2024, 11:53 AM
View All 84 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGe5248548f95f: procfs: return right hardlink from /proc/curproc/file
rGf34fc6ba06a1: Extract proc_get_binpath() from sysctl_kern_proc_pathname()
rGb4c7d45c8490: sys/proc.h: put proc_add_orphan() into proper place
Summary

Extract proc_get_binpath() from sysctl_kern_proc_pathname().
Use proc_get_binpath() to get the hardlink right.

PR: 248184

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 29 2021, 8:18 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 29 2021, 8:18 PM
kib requested review of this revision.Oct 29 2021, 8:18 PM
markj accepted this revision.Oct 29 2021, 9:54 PM
markj added inline comments.
sys/kern/kern_proc.c
2252 ↗(On Diff #97683)

Perhaps have the caller pass an explicit size instead of assuming MAXPATHLEN. Or at least have a comment above the function noting that it must be MAXPATHLEN bytes in size.

2316 ↗(On Diff #97683)

If you write

if (error == 0)
    proc_get_binpath(...);
free(binname, M_TEMP);
if (error != 0)
    return (error);

then the error handling for pget() is not needed.

sys/sys/proc.h
1143

Keep it sorted? It's almost there, except for proc_add_orphan().

This revision is now accepted and ready to land.Oct 29 2021, 9:54 PM
kib updated this revision to Diff 97691.Oct 29 2021, 10:15 PM
kib marked 3 inline comments as done.

Add detailed herald comment for proc_get_binpath()
Simplify control flow in sysctl
Reorder proc_ declarations in sys/proc.h

This revision now requires review to proceed.Oct 29 2021, 10:15 PM
markj accepted this revision.Oct 30 2021, 2:16 PM
markj added inline comments.
sys/kern/kern_proc.c
2231 ↗(On Diff #97691)
This revision is now accepted and ready to land.Oct 30 2021, 2:16 PM
emaste accepted this revision.Oct 30 2021, 2:49 PM
Closed by commit rGb4c7d45c8490: sys/proc.h: put proc_add_orphan() into proper place (authored by kib). · Explain WhyOct 31 2021, 1:05 AM
This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.
kib added a commit: rGb4c7d45c8490: sys/proc.h: put proc_add_orphan() into proper place.
kib added a commit: rGf34fc6ba06a1: Extract proc_get_binpath() from sysctl_kern_proc_pathname().
kib added a commit: rGe5248548f95f: procfs: return right hardlink from /proc/curproc/file.

Revision Contents
Changeset List

PathSize
sys/
sys/
2 lines

Diff 97756

View Options

sys/sys/proc.h

Loading...