Page MenuHomeFreeBSD
Differential D31163

Add sysctl vm.objects_swap
ClosedPublic
Actions

Authored by kib on Jul 13 2021, 10:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 14, 8:33 AM
Unknown Object (File)
Thu, Nov 13, 3:25 AM
Unknown Object (File)
Tue, Nov 11, 2:45 AM
Unknown Object (File)
Wed, Nov 5, 3:33 AM
Unknown Object (File)
Wed, Nov 5, 3:32 AM
Unknown Object (File)
Wed, Nov 5, 3:32 AM
Unknown Object (File)
Wed, Nov 5, 3:32 AM
Unknown Object (File)
Wed, Nov 5, 3:31 AM
View All Files
Subscribers
imp
mckusick
merv_soundabstractions.io
ota_j.email.ne.jp

Details

Reviewers
alc
markj
Commits
rG350fc36b4cf8: sysctl vm.objects: yield if hog
rG7738118e9a29: vm.objects_swap: disable reporting some information
rG42812ccc969f: Add vm.swap_objects sysctl
rG1b610624fdc8: vm_object_list: split sysctl handler in separate function
Summary

vm.objects_swap: disable reporting some information

For making the call faster, do not count active/inactive object queues, and do not report vnode info if any (for tmpfs).

See D29754

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Jul 13 2021, 10:37 AM
kib created this revision.
kib mentioned this in D29754: Augment systat(1) -swap to display large swap space processes.Jul 13 2021, 10:43 AM
kib updated this revision to Diff 92206.Jul 15 2021, 12:06 AM

Add the 'yield if hog' patch

kib added reviewers: alc, markj.Oct 23 2021, 4:40 PM
kib added subscribers: mckusick, ota_j.email.ne.jp.
Herald added a subscriber: imp. · View Herald TranscriptOct 23 2021, 4:40 PM
kib edited the summary of this revision. (Show Details)Oct 23 2021, 4:41 PM
markj added inline comments.Oct 25 2021, 12:55 PM
sys/vm/vm_object.c
2517

Why examine objects with OBJ_ANON set and OBJ_SWAP clear?

kib added inline comments.Oct 25 2021, 1:03 PM
sys/vm/vm_object.c
2517

Because these are logically swap objects. The fact that the system yet did not swapped anything from their page queue does not imply anything.

Hm, even more, if I skip such objects there, then sysinfo(8) would not be able to reconstruct full shadow chain. So it is not the question of interpretation, but in fact required to do.

markj accepted this revision.Oct 25 2021, 1:18 PM
markj added inline comments.
sys/vm/vm_object.c
2517

I think this deserves a comment, then, since swap_only is not quite accurate. Naively I understand that the new sysctl is used to display information about swap usage, and it is tempting to "optimize" this loop by excluding OBJT_DEFAULT objects since by definition they have never undergone pageouts.

2552–2553

You could avoid calling pgo_getvp calls in vm_object_kvme_type() by passing swap_only ? NULL : &vp instead (with vp initialized to NULL).

This revision is now accepted and ready to land.Oct 25 2021, 1:18 PM
kib updated this revision to Diff 97393.Oct 25 2021, 1:45 PM
kib marked 3 inline comments as done.

Optimize vp calculation.
Add detailed comment about new sysctl.

This revision now requires review to proceed.Oct 25 2021, 1:45 PM
markj accepted this revision.Oct 25 2021, 1:56 PM
This revision is now accepted and ready to land.Oct 25 2021, 1:56 PM
Closed by commit rG1b610624fdc8: vm_object_list: split sysctl handler in separate function (authored by kib). · Explain WhyOct 25 2021, 5:34 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG1b610624fdc8: vm_object_list: split sysctl handler in separate function.
kib added a commit: rG42812ccc969f: Add vm.swap_objects sysctl.
kib added a commit: rG7738118e9a29: vm.objects_swap: disable reporting some information.
kib added a commit: rG350fc36b4cf8: sysctl vm.objects: yield if hog.
merv_soundabstractions.io added a subscriber: merv_soundabstractions.io.Oct 25 2021, 5:40 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
67 lines

Diff 97393

View Options

sys/vm/vm_object.c

Loading...