urtwn(4): fix scanning from AUTH state
ClosedPublic
Actions

Authored by avos on Oct 21 2015, 8:24 PM.

Details

Reviewers

kevlo
adrian

Commits

rS290048: urtwn(4): fix scanning from AUTH state

Test Plan

Tested with RTL8188EU, STA mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9591.Oct 21 2015, 8:24 PM

avos retitled this revision from to urtwn(4): fix scanning from AUTH state.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 21 2015, 8:24 PM

Hi!

This is good. How about also refactoring out the "any bssid" rxfilter set/clear bit there into a separate function too? That way it's

urtwn_set_rx_bssid_all(sc, 1);
urtwn_set_gain(sc, xxX);

.. for scan, etc?

In D3968#82651, @adrian wrote:

Hi!

This is good. How about also refactoring out the "any bssid" rxfilter set/clear bit there into a separate function too? That way it's

urtwn_set_rx_bssid_all(sc, 1);
urtwn_set_gain(sc, xxX);

.. for scan, etc?

why not?

avos added a child revision: D3999: urtwn(4): improve RX filter.Oct 25 2015, 11:40 AM

Looks good!

This revision is now accepted and ready to land.Oct 26 2015, 11:50 AM

kevlo accepted this revision.Oct 27 2015, 9:35 AM

kevlo edited edge metadata.

Closed by commit rS290048: urtwn(4): fix scanning from AUTH state (authored by avos). · Explain WhyOct 27 2015, 2:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_urtwn.c

77 lines

Diff 9736

View Options

head/sys/dev/usb/wlan/if_urtwn.c

Show First 20 Lines • Show All 985 Lines • ▼ Show 20 Lines	#endif
* march through the device switch probing for things.		* march through the device switch probing for things.
*/		*/
i = efipart_inithandles();		i = efipart_inithandles();
if (i != 0 && i != ENOENT) {		if (i != 0 && i != ENOENT) {
printf("efipart_inithandles failed with ERRNO %d, expect "		printf("efipart_inithandles failed with ERRNO %d, expect "
"failures\n", i);		"failures\n", i);
}		}

for (i = 0; devsw[i] != NULL; i++)		devinit();
if (devsw[i]->dv_init != NULL)
(devsw[i]->dv_init)();

/*		/*
* Detect console settings two different ways: one via the command		* Detect console settings two different ways: one via the command
* args (eg -h) or via the UEFI ConOut variable.		* args (eg -h) or via the UEFI ConOut variable.
*/		*/
has_kbd = has_keyboard();		has_kbd = has_keyboard();
howto = parse_args(argc, argv);		howto = parse_args(argc, argv);
if (!has_kbd && (howto & RB_PROBE))		if (!has_kbd && (howto & RB_PROBE))
▲ Show 20 Lines • Show All 727 Lines • Show Last 20 Lines

urtwn(4): fix scanning from AUTH stateClosedPublicActions