Differential D4487

urtwn: fix frame processing in the Rx path
ClosedPublic
Actions

Authored by avos on Dec 10 2015, 8:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 7:08 PM

	Unknown Object (File)
	Tue, Oct 14, 5:08 AM

	Unknown Object (File)
	Tue, Oct 14, 12:17 AM

	Unknown Object (File)
	Sat, Oct 11, 6:20 AM

	Unknown Object (File)
	Sep 4 2025, 6:37 AM

	Unknown Object (File)
	Aug 19 2025, 10:39 PM

	Unknown Object (File)
	Aug 16 2025, 1:33 PM

	Unknown Object (File)
	Aug 15 2025, 7:35 AM

Subscribers

Details

Reviewers

kevlo
adrian

Commits

rS292207: urtwn: fix frame processing in the Rx path.

Summary

Currently, when npkts >= 2, RSSI and Rx radiotap fields will be overridden by the next packet.
As a result, every packet from this chain will use the same RSSI / radiotap data.
After this patch, RSSI and radiotap structure will be filled for every frame right before ieee80211_input() call.

Test Plan

Tested with RTL8188EU / RTL8188CUS, STA and MONITOR modes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 11047.Dec 10 2015, 8:53 PM

avos retitled this revision from to urtwn: fix frame processing in the Rx path.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2015, 8:53 PM

avos added parent revisions: D3831: urtwn(4): add TSF field into RX radiotap header, D3832: urtwn(4): setup channel frequency/flags for radiotap in urtwn_set_channel(), D4402: urtwn: add rate control support for RTL8188EU.Dec 10 2015, 8:54 PM

avos added a parent revision: D4448: urtwn: add support for hardware encryption (WEP, TKIP and CCMP).Dec 11 2015, 9:28 PM

Yup, good catch.

This revision is now accepted and ready to land.Dec 13 2015, 9:33 PM

kevlo accepted this revision.Dec 14 2015, 1:26 AM

kevlo edited edge metadata.

Closed by commit rS292207: urtwn: fix frame processing in the Rx path. (authored by avos). · Explain WhyDec 14 2015, 1:05 PM

This revision was automatically updated to reflect the committed changes.

rsu(4) is affected too.

Yeah, I need to fix rsu too. :( I noticed that when i was making it do 11n.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

209 lines

Diff 11229

head/sys/dev/usb/wlan/if_urtwn.c

Loading...