Page MenuHomeFreeBSD
Differential D4274

urtwn(4): add ROM structure for RTL8188EU
ClosedPublic
Actions

Authored by avos on Nov 25 2015, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 5:06 PM
Unknown Object (File)
Sun, Nov 3, 4:53 PM
Unknown Object (File)
Sep 24 2024, 4:02 AM
Unknown Object (File)
Sep 22 2024, 7:20 PM
Unknown Object (File)
Sep 22 2024, 3:42 AM
Unknown Object (File)
Sep 17 2024, 4:36 PM
Unknown Object (File)
Sep 17 2024, 6:17 AM
Unknown Object (File)
Sep 17 2024, 5:06 AM
View All 72 Files
Subscribers
imp

Details

Reviewers
kevlo
adrian
Commits
rS294198: urtwn: add ROM structure for RTL8188EU
Summary

Add the structure with already known fields offsets (some of them were taken from this driver, some (channel_plan, rf_* fields) - from TP-LINK official driver) + fix a typo / dehardcode a constant in RTL8192C ROM structure.

Test Plan

Tested with RTL8188EU, STA mode

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 10496.Nov 25 2015, 6:43 PM
avos retitled this revision from to urtwn(4): add ROM structure for RTL8188EU.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: adrian, kevlo.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2015, 6:43 PM
kevlo accepted this revision.Nov 26 2015, 8:30 AM
kevlo edited edge metadata.

There are two minor style bugs, the rest looks good, thanks.

sys/dev/usb/wlan/if_urtwnreg.h
968 ↗(On Diff #10496)

style bug.

969 ↗(On Diff #10496)

style bug.

This revision is now accepted and ready to land.Nov 26 2015, 8:30 AM
avos added inline comments.Nov 29 2015, 10:53 PM
sys/dev/usb/wlan/if_urtwnreg.h
968 ↗(On Diff #10496)

it's not a style bug - look on it via 'download raw diff'
(probably, phabricator implicitly converts tabs into spaces)

kevlo added a comment.Nov 30 2015, 1:31 AM

Looks good, thanks.

avos added a child revision: D4959: urtwn: rework debug handling.Jan 16 2016, 4:29 PM
adrian accepted this revision.Jan 16 2016, 10:22 PM
adrian edited edge metadata.
Closed by commit rS294198: urtwn: add ROM structure for RTL8188EU (authored by avos). · Explain WhyJan 17 2016, 12:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
usb/
wlan/
28 lines
34 lines
8 lines

Diff 12377

View Options

head/sys/dev/usb/wlan/if_urtwn.c

Loading...
View Options

head/sys/dev/usb/wlan/if_urtwnreg.h

Loading...
View Options

head/sys/dev/usb/wlan/if_urtwnvar.h

Loading...