Differential D3832

urtwn(4): setup channel frequency/flags for radiotap in urtwn_set_channel()
ClosedPublic
Actions

Authored by avos on Oct 6 2015, 9:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 28, 2:29 PM

	Unknown Object (File)
	Fri, Sep 19, 12:59 AM

	Unknown Object (File)
	Wed, Sep 17, 7:39 PM

	Unknown Object (File)
	Aug 20 2025, 7:23 PM

	Unknown Object (File)
	Aug 14 2025, 9:21 PM

	Unknown Object (File)
	Aug 14 2025, 9:19 PM

	Unknown Object (File)
	Aug 4 2025, 4:20 AM

	Unknown Object (File)
	Aug 2 2025, 10:26 PM

Subscribers

Details

Reviewers

kevlo
adrian

Commits

rS292173: urtwn(4): setup channel frequency/flags for radiotap in urtwn_set_channel()

Summary

Assign these variables only when channel changes, not once per every frame.

Test Plan

Tested with RTL8188EU, STA mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9199.Oct 6 2015, 9:53 PM

avos retitled this revision from to urtwn(4): setup channel frequency/flags for radiotap in urtwn_set_channel().

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2015, 9:53 PM

avos added a child revision: D4017: urtwn(4): refactor/fix TX path.Oct 27 2015, 6:40 PM

kevlo accepted this revision.Oct 29 2015, 2:56 PM

kevlo edited edge metadata.

This revision is now accepted and ready to land.Oct 29 2015, 2:56 PM

avos mentioned this in D4034: urtwn(4): add HOSTAP mode support.Nov 8 2015, 11:31 PM

avos added a child revision: D4487: urtwn: fix frame processing in the Rx path.Dec 10 2015, 8:54 PM

Yeah, this is fine considering how radiotap is currently implemented (ie with things hiding radiotap structs in softc. sigh.)

Closed by commit rS292173: urtwn(4): setup channel frequency/flags for radiotap in urtwn_set_channel() (authored by avos). · Explain WhyDec 13 2015, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

11 lines

Diff 11206

head/sys/dev/usb/wlan/if_urtwn.c

Loading...