Page MenuHomeFreeBSD
Differential D3968

urtwn(4): fix scanning from AUTH state
ClosedPublic
Actions

Authored by avos on Oct 21 2015, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 29, 5:35 PM
Unknown Object (File)
Mon, Sep 28, 5:05 PM
Unknown Object (File)
Mon, Sep 28, 5:02 PM
Unknown Object (File)
Mon, Sep 28, 4:54 PM
Unknown Object (File)
Sun, Sep 27, 2:27 PM
Unknown Object (File)
Sun, Sep 27, 12:53 AM
Unknown Object (File)
Sat, Sep 26, 2:23 AM
Unknown Object (File)
Wed, Sep 23, 9:01 PM
View All Files
Subscribers
imp

Details

Reviewers
kevlo
adrian
Commits
rS290048: urtwn(4): fix scanning from AUTH state
Test Plan

Tested with RTL8188EU, STA mode.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9591.Oct 21 2015, 8:24 PM
avos retitled this revision from to urtwn(4): fix scanning from AUTH state.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: adrian, kevlo.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptOct 21 2015, 8:24 PM
adrian edited edge metadata.Oct 21 2015, 8:27 PM

Hi!

This is good. How about also refactoring out the "any bssid" rxfilter set/clear bit there into a separate function too? That way it's

urtwn_set_rx_bssid_all(sc, 1);
urtwn_set_gain(sc, xxX);

.. for scan, etc?

avos updated this revision to Diff 9592.Oct 21 2015, 8:45 PM
avos edited edge metadata.
In D3968#82651, @adrian wrote:

Hi!

This is good. How about also refactoring out the "any bssid" rxfilter set/clear bit there into a separate function too? That way it's

urtwn_set_rx_bssid_all(sc, 1);
urtwn_set_gain(sc, xxX);

.. for scan, etc?

why not?

avos added a child revision: D3999: urtwn(4): improve RX filter.Oct 25 2015, 11:40 AM
adrian accepted this revision.Oct 26 2015, 11:50 AM
adrian edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Oct 26 2015, 11:50 AM
kevlo accepted this revision.Oct 27 2015, 9:35 AM
kevlo edited edge metadata.
Closed by commit rS290048: urtwn(4): fix scanning from AUTH state (authored by avos). · Explain WhyOct 27 2015, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
usb/
wlan/
77 lines

Diff 9736

View Options

head/sys/dev/usb/wlan/if_urtwn.c

Loading...