Page MenuHomeFreeBSD

Allow the BPF to be select for EVFILT_WRITE with kqueue.
ClosedPublic

Authored by harti on Sep 15 2021, 8:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 23, 1:21 AM
Unknown Object (File)
Wed, Apr 22, 3:11 PM
Unknown Object (File)
Wed, Apr 22, 5:17 AM
Unknown Object (File)
Tue, Apr 21, 6:21 PM
Unknown Object (File)
Tue, Apr 21, 2:06 AM
Unknown Object (File)
Mon, Apr 20, 5:36 AM
Unknown Object (File)
Sun, Apr 19, 10:27 PM
Unknown Object (File)
Sun, Apr 19, 2:16 AM
Subscribers

Details

Summary

Allow the BPF to be select for EVFILT_WRITE with kqueue. This is required for Boost asio to be able to use a BPF file descriptor even if it is used only for reading. Asio insists on installing a write filter.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41847
Build 38735: arc lint + arc unit

Event Timeline

harti requested review of this revision.Sep 15 2021, 8:35 AM
sys/net/bpf.c
2193

I'd prefer a bit less code duplication:

struct filterops *ops;

...

switch (kn->kn_filter) {
case EVFILT_READ:
   ops = &bpfread_filtops;
   break;
case EVFILT_WRITE:
   ops = &bpwrite_filtops;
   break;
default:
   return (EINVAL);
}

...

Also it seems you need to modify kqueue(2).

Reduce code duplication.
Update kqueue.2.

This revision is now accepted and ready to land.Oct 1 2021, 8:03 AM