kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic
Actions

Authored by jhb on Sep 13 2021, 6:10 PM.

Details

Reviewers

emaste
kib

Commits

rG9d8607fa3fab: kernel: Disable errors for -Walloca-larger-than for GCC.
rGed05f8fbeae7: kernel: Disable errors for -Walloca-larger-than for GCC.
rGe72c7e2738ca: kernel: Disable errors for -Walloca-larger-than for GCC.

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 13 2021, 6:10 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2021, 6:10 PM

jhb requested review of this revision.Sep 13 2021, 6:10 PM

Harbormaster completed remote builds in B41488: Diff 95058.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM