Page MenuHomeFreeBSD

socket: Add assertions around naked refcount decrements
ClosedPublic

Authored by markj on Sep 15 2021, 7:58 PM.
Tags
None
Referenced Files
F170747996: D31974.id.diff
Sun, Sep 6, 9:42 AM
F170731590: D31974.id95227.diff
Sun, Sep 6, 6:52 AM
F170708182: D31974.id.diff
Sun, Sep 6, 3:30 AM
F170601203: D31974.id95319.diff
Sat, Sep 5, 2:29 PM
Unknown Object (File)
Sat, Sep 5, 11:35 AM
Unknown Object (File)
Wed, Sep 2, 9:56 PM
Unknown Object (File)
Wed, Sep 2, 9:34 PM
Unknown Object (File)
Tue, Sep 1, 4:59 PM
Subscribers

Details

Summary

Sockets in a listen queue hold a reference to the parent listening
socket. Several code paths release this reference manually when moving
a child socket out of the queue.

Replace comments about the expected post-decrement refcount value with
assertions. Use refcount_load() instead of a plain load. No functional
change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable