Page MenuHomeFreeBSD

socket: Add assertions around naked refcount decrements
ClosedPublic

Authored by markj on Sep 15 2021, 7:58 PM.
Tags
None
Referenced Files
F167507620: D31974.id95227.diff
Sat, Aug 22, 9:09 AM
F167503603: D31974.id95227.diff
Sat, Aug 22, 8:39 AM
Unknown Object (File)
Fri, Aug 21, 3:10 PM
Unknown Object (File)
Thu, Aug 20, 4:37 AM
Unknown Object (File)
Wed, Aug 12, 10:03 PM
Unknown Object (File)
Tue, Aug 11, 10:30 AM
Unknown Object (File)
Mon, Aug 10, 9:26 AM
Unknown Object (File)
Sun, Aug 9, 3:24 PM
Subscribers

Details

Summary

Sockets in a listen queue hold a reference to the parent listening
socket. Several code paths release this reference manually when moving
a child socket out of the queue.

Replace comments about the expected post-decrement refcount value with
assertions. Use refcount_load() instead of a plain load. No functional
change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41534
Build 38423: arc lint + arc unit