Page MenuHomeFreeBSD

Allow the BPF to be select for EVFILT_WRITE with kqueue.
ClosedPublic

Authored by harti on Sep 15 2021, 8:35 AM.
Tags
None
Referenced Files
F169829567: D31967.diff
Wed, Sep 2, 5:01 PM
Unknown Object (File)
Wed, Sep 2, 8:57 AM
Unknown Object (File)
Wed, Sep 2, 5:40 AM
Unknown Object (File)
Wed, Sep 2, 1:08 AM
Unknown Object (File)
Tue, Sep 1, 11:24 PM
Unknown Object (File)
Tue, Sep 1, 7:53 PM
Unknown Object (File)
Mon, Aug 31, 5:23 PM
Unknown Object (File)
Mon, Aug 31, 5:36 AM
Subscribers

Details

Summary

Allow the BPF to be select for EVFILT_WRITE with kqueue. This is required for Boost asio to be able to use a BPF file descriptor even if it is used only for reading. Asio insists on installing a write filter.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41523
Build 38412: arc lint + arc unit

Event Timeline

harti requested review of this revision.Sep 15 2021, 8:35 AM
sys/net/bpf.c
2200

I'd prefer a bit less code duplication:

struct filterops *ops;

...

switch (kn->kn_filter) {
case EVFILT_READ:
   ops = &bpfread_filtops;
   break;
case EVFILT_WRITE:
   ops = &bpwrite_filtops;
   break;
default:
   return (EINVAL);
}

...

Also it seems you need to modify kqueue(2).

Reduce code duplication.
Update kqueue.2.

This revision is now accepted and ready to land.Oct 1 2021, 8:03 AM