Differential D31686

ses: minor cleanup
ClosedPublic
Actions

Authored by asomers on Aug 25 2021, 9:11 PM.

Tags

None

Referenced Files

	F163617399: D31686.id101649.diff
	Fri, Jul 24, 9:52 PM

	Unknown Object (File)
	Mon, Jul 20, 10:47 PM

	Unknown Object (File)
	Mon, Jul 20, 11:03 AM

	Unknown Object (File)
	Sun, Jul 19, 10:29 PM

	Unknown Object (File)
	Tue, Jul 14, 7:10 PM

	Unknown Object (File)
	Tue, Jul 7, 10:06 PM

	Unknown Object (File)
	Mon, Jul 6, 7:02 AM

	Unknown Object (File)
	Sun, Jul 5, 2:01 AM

Subscribers

Details

Reviewers

ken
mav
allanjude

Group Reviewers

Commits

rG96d0f07d08a9: ses: minor cleanup
rG170a0a8ebbd3: ses: minor cleanup

Summary

Prefer variables of small scope rather than large scope
Remove a magic number
style(9) for return statements
Remove the get_enc_status method, which never did anything
Proofread some comments

MFC after: 2 weeks
Sponsored by: Spectra Logic, Axcient

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41218
Build 38107: arc lint + arc unit

Event Timeline

asomers created this revision.Aug 25 2021, 9:11 PM

Herald added a reviewer: cam. · View Herald TranscriptAug 25 2021, 9:11 PM

Herald added a subscriber: imp. · View Herald Transcript

asomers requested review of this revision.Aug 25 2021, 9:11 PM

Harbormaster completed remote builds in B41217: Diff 94197.Aug 25 2021, 9:11 PM

Fix the commit message

Harbormaster completed remote builds in B41218: Diff 94198.Aug 25 2021, 9:13 PM

ken accepted this revision.Jan 19 2022, 6:29 PM

This revision is now accepted and ready to land.Jan 19 2022, 6:29 PM

Looks good to me. I was just thinking recently whether we could bury SAF-TE support and all this indirection one day. My only SAF-TE enclosure is parallel SCSI I haven't touched for 5 years.

Closed by commit rG170a0a8ebbd3: ses: minor cleanup (authored by asomers). · Explain WhyJan 19 2022, 7:09 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG170a0a8ebbd3: ses: minor cleanup.

asomers added a commit: rG96d0f07d08a9: ses: minor cleanup.Feb 17 2022, 4:34 AM

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

16 lines

54 lines

scsi_enc_internal.h

5 lines

scsi_enc_safte.c

8 lines

14 lines

Diff 94198

sys/cam/scsi/scsi_enc.h

Loading...

sys/cam/scsi/scsi_enc.c

Loading...

sys/cam/scsi/scsi_enc_internal.h

Loading...

sys/cam/scsi/scsi_enc_safte.c

Loading...

sys/cam/scsi/scsi_enc_ses.c

Loading...