Page MenuHomeFreeBSD
Differential D31686

ses: minor cleanup
ClosedPublic
Actions

Authored by asomers on Aug 25 2021, 9:11 PM.
Tags
None
Referenced Files
F149064315: D31686.id101649.diff
Sun, Mar 22, 2:20 AM
Unknown Object (File)
Sat, Mar 21, 5:26 AM
Unknown Object (File)
Fri, Mar 20, 3:15 AM
Unknown Object (File)
Thu, Mar 19, 9:48 PM
Unknown Object (File)
Tue, Mar 17, 1:14 PM
Unknown Object (File)
Tue, Mar 17, 1:08 PM
Unknown Object (File)
Thu, Mar 12, 4:58 PM
Unknown Object (File)
Thu, Mar 12, 2:20 PM
View All Files
Subscribers
imp

Details

Reviewers
ken
mav
allanjude
Group Reviewers
cam
Commits
rG96d0f07d08a9: ses: minor cleanup
rG170a0a8ebbd3: ses: minor cleanup
Summary
  • Prefer variables of small scope rather than large scope
  • Remove a magic number
  • style(9) for return statements
  • Remove the get_enc_status method, which never did anything
  • Proofread some comments

MFC after: 2 weeks
Sponsored by: Spectra Logic, Axcient

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41218
Build 38107: arc lint + arc unit

Event Timeline

asomers created this revision.Aug 25 2021, 9:11 PM
Herald added a reviewer: cam. · View Herald TranscriptAug 25 2021, 9:11 PM
Herald added a subscriber: imp. · View Herald Transcript
asomers requested review of this revision.Aug 25 2021, 9:11 PM
Harbormaster completed remote builds in B41217: Diff 94197.Aug 25 2021, 9:11 PM
asomers updated this revision to Diff 94198.Aug 25 2021, 9:13 PM

Fix the commit message

Harbormaster completed remote builds in B41218: Diff 94198.Aug 25 2021, 9:13 PM
ken accepted this revision.Jan 19 2022, 6:29 PM
This revision is now accepted and ready to land.Jan 19 2022, 6:29 PM
mav accepted this revision.Jan 19 2022, 7:04 PM

Looks good to me. I was just thinking recently whether we could bury SAF-TE support and all this indirection one day. My only SAF-TE enclosure is parallel SCSI I haven't touched for 5 years.

Closed by commit rG170a0a8ebbd3: ses: minor cleanup (authored by asomers). · Explain WhyJan 19 2022, 7:09 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG170a0a8ebbd3: ses: minor cleanup.
asomers added a commit: rG96d0f07d08a9: ses: minor cleanup.Feb 17 2022, 4:34 AM

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
16 lines
54 lines
5 lines
8 lines
14 lines

Diff 94198

View Options

sys/cam/scsi/scsi_enc.h

Loading...
View Options

sys/cam/scsi/scsi_enc.c

Loading...
View Options

sys/cam/scsi/scsi_enc_internal.h

Loading...
View Options

sys/cam/scsi/scsi_enc_safte.c

Loading...
View Options

sys/cam/scsi/scsi_enc_ses.c

Loading...