Details

Reviewers

None

Group Reviewers

Commits

rP399278: Drop the necessity to add ${PORTSDIR} to dependency line

Summary

Remove now uneeded extra ${PORTSDIR}/ in dependencies the recent changes in
dependency handling makes it possible to not add this extra MACRO

I have done minimal testing with portupgrade/portinstall

The only known failure is make_index I'm working on it

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 9300.Oct 10 2015, 6:30 PM

bapt retitled this revision from to Remove now uneeded extra ${PORTSDIR}/ in dependencies.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added a reviewer: portmgr.

Herald edited edge metadata. · View Herald TranscriptOct 10 2015, 6:30 PM

make_index now happy

Herald edited edge metadata. · View Herald TranscriptOct 10 2015, 7:01 PM

Fix a typo

Herald edited edge metadata. · View Herald TranscriptOct 10 2015, 7:04 PM

I'm all for that, but won't it break portmaster or portupgrade ?

In D3866#80057, @mat wrote:

I'm all for that, but won't it break portmaster or portupgrade ?

As said in the summary I have tested both of them (installing stuff only) and it worked

antoine added a subscriber: antoine.Oct 12 2015, 8:57 PM

antoine added inline comments.

Mk/Uses/blaslapack.mk
27 ↗	(On Diff #9304)	This line looks wrong
Mk/Uses/pear.mk
79 ↗	(On Diff #9304)	This looks wrong
142 ↗	(On Diff #9304)	this looks wrong
Mk/Uses/python.mk
385 ↗	(On Diff #9304)	this looks wrong

Address Antoine's comments

Herald edited edge metadata. · View Herald TranscriptOct 13 2015, 12:24 PM

antoine added inline comments.Oct 13 2015, 12:33 PM

Mk/Uses/gnustep.mk
45 ↗	(On Diff #9347)	This one too, but it's commented out I will start exp run

koobs added a subscriber: koobs.Oct 13 2015, 1:17 PM

there is a problem during make index due to the change in Uses/python.mk

make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status

Readd a ${PORTSDIR} to please make index with python

Herald edited edge metadata. · View Herald TranscriptOct 13 2015, 1:26 PM

Closed by commit rP399278: Drop the necessity to add ${PORTSDIR} to dependency line (authored by bapt). · Explain WhyOct 14 2015, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Remove now uneeded extra ${PORTSDIR}/ in dependenciesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9384

head/CHANGES

head/Mk/Uses/ada.mk

head/Mk/Uses/autoreconf.mk

head/Mk/Uses/bison.mk

head/Mk/Uses/blaslapack.mk

head/Mk/Uses/cmake.mk

head/Mk/Uses/compiler.mk

head/Mk/Uses/cran.mk

head/Mk/Uses/desktop-file-utils.mk

head/Mk/Uses/display.mk

head/Mk/Uses/drupal.mk

head/Mk/Uses/elixir.mk

head/Mk/Uses/erlang.mk

head/Mk/Uses/execinfo.mk

head/Mk/Uses/fakeroot.mk

head/Mk/Uses/fam.mk

head/Mk/Uses/fmake.mk

head/Mk/Uses/fonts.mk

head/Mk/Uses/fortran.mk

head/Mk/Uses/fuse.mk

head/Mk/Uses/gecko.mk

head/Mk/Uses/gettext-runtime.mk

head/Mk/Uses/gettext-tools.mk

head/Mk/Uses/ghostscript.mk

head/Mk/Uses/gmake.mk

head/Mk/Uses/gnustep.mk

head/Mk/Uses/gperf.mk

head/Mk/Uses/gssapi.mk

head/Mk/Uses/horde.mk

head/Mk/Uses/iconv.mk

head/Mk/Uses/imake.mk

head/Mk/Uses/jpeg.mk

head/Mk/Uses/lha.mk

head/Mk/Uses/libarchive.mk

head/Mk/Uses/libedit.mk

head/Mk/Uses/libtool.mk

head/Mk/Uses/lua.mk

head/Mk/Uses/makeinfo.mk

head/Mk/Uses/makeself.mk

head/Mk/Uses/mono.mk

head/Mk/Uses/motif.mk

head/Mk/Uses/ncurses.mk

head/Mk/Uses/ninja.mk

head/Mk/Uses/objc.mk

head/Mk/Uses/openal.mk

head/Mk/Uses/pear.mk

head/Mk/Uses/perl5.mk

head/Mk/Uses/pgsql.mk

head/Mk/Uses/pkgconfig.mk

head/Mk/Uses/pure.mk

head/Mk/Uses/python.mk

head/Mk/Uses/qmail.mk

head/Mk/Uses/readline.mk

head/Mk/Uses/scons.mk

head/Mk/Uses/shared-mime-info.mk

head/Mk/Uses/tcl.mk

head/Mk/Uses/twisted.mk

head/Mk/Uses/xfce.mk

head/Mk/Uses/zip.mk

head/Mk/Uses/zope.mk

head/Mk/bsd.port.mk

head/Mk/bsd.qt.mk

head/Mk/bsd.ruby.mk

head/Mk/bsd.sdl.mk

head/Mk/bsd.tex.mk

head/Mk/bsd.wx.mk

head/Mk/bsd.xorg.mk

Remove now uneeded extra ${PORTSDIR}/ in dependencies
ClosedPublic
Actions

Revision Contents
Changeset List