Page MenuHomeFreeBSD

Remove now uneeded extra ${PORTSDIR}/ in dependencies
ClosedPublic

Authored by bapt on Oct 10 2015, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 9:18 PM
Unknown Object (File)
Mon, May 20, 9:18 PM
Unknown Object (File)
Mon, May 20, 9:18 PM
Unknown Object (File)
Mon, May 20, 9:17 PM
Unknown Object (File)
Mon, May 20, 9:17 PM
Unknown Object (File)
Mon, May 20, 9:17 PM
Unknown Object (File)
Mon, May 20, 9:17 PM
Unknown Object (File)
Fri, May 17, 10:22 PM
Subscribers

Details

Summary

Remove now uneeded extra ${PORTSDIR}/ in dependencies the recent changes in
dependency handling makes it possible to not add this extra MACRO

I have done minimal testing with portupgrade/portinstall

The only known failure is make_index I'm working on it

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt retitled this revision from to Remove now uneeded extra ${PORTSDIR}/ in dependencies.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
bapt edited edge metadata.

make_index now happy

bapt edited edge metadata.

Fix a typo

I'm all for that, but won't it break portmaster or portupgrade ?

In D3866#80057, @mat wrote:

I'm all for that, but won't it break portmaster or portupgrade ?

As said in the summary I have tested both of them (installing stuff only) and it worked

antoine added inline comments.
Mk/Uses/blaslapack.mk
27 ↗(On Diff #9304)

This line looks wrong

Mk/Uses/pear.mk
79 ↗(On Diff #9304)

This looks wrong

142 ↗(On Diff #9304)

this looks wrong

Mk/Uses/python.mk
385 ↗(On Diff #9304)

this looks wrong

bapt edited edge metadata.

Address Antoine's comments

Mk/Uses/gnustep.mk
45 ↗(On Diff #9347)

This one too, but it's commented out
I will start exp run

there is a problem during make index due to the change in Uses/python.mk

make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status

bapt edited edge metadata.

Readd a ${PORTSDIR} to please make index with python

This revision was automatically updated to reflect the committed changes.