Page MenuHomeFreeBSD

Remove now uneeded extra ${PORTSDIR}/ in dependencies
ClosedPublic

Authored by bapt on Oct 10 2015, 6:30 PM.

Details

Summary

Remove now uneeded extra ${PORTSDIR}/ in dependencies the recent changes in
dependency handling makes it possible to not add this extra MACRO

I have done minimal testing with portupgrade/portinstall

The only known failure is make_index I'm working on it

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bapt updated this revision to Diff 9300.Oct 10 2015, 6:30 PM
bapt retitled this revision from to Remove now uneeded extra ${PORTSDIR}/ in dependencies.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
bapt updated this revision to Diff 9303.Oct 10 2015, 7:01 PM
bapt edited edge metadata.

make_index now happy

bapt updated this revision to Diff 9304.Oct 10 2015, 7:04 PM
bapt edited edge metadata.

Fix a typo

mat added a subscriber: mat.Oct 10 2015, 10:09 PM

I'm all for that, but won't it break portmaster or portupgrade ?

bapt added a comment.Oct 10 2015, 10:13 PM
In D3866#80057, @mat wrote:

I'm all for that, but won't it break portmaster or portupgrade ?

As said in the summary I have tested both of them (installing stuff only) and it worked

antoine added inline comments.
Mk/Uses/blaslapack.mk
27 ↗(On Diff #9304)

This line looks wrong

Mk/Uses/pear.mk
79 ↗(On Diff #9304)

This looks wrong

142 ↗(On Diff #9304)

this looks wrong

Mk/Uses/python.mk
385 ↗(On Diff #9304)

this looks wrong

bapt updated this revision to Diff 9347.Oct 13 2015, 12:24 PM
bapt edited edge metadata.

Address Antoine's comments

antoine added inline comments.Oct 13 2015, 12:33 PM
Mk/Uses/gnustep.mk
45 ↗(On Diff #9347)

This one too, but it's commented out
I will start exp run

koobs added a subscriber: koobs.Oct 13 2015, 1:17 PM

there is a problem during make index due to the change in Uses/python.mk

make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status

bapt updated this revision to Diff 9348.Oct 13 2015, 1:26 PM
bapt edited edge metadata.

Readd a ${PORTSDIR} to please make index with python

This revision was automatically updated to reflect the committed changes.