Page MenuHomeFreeBSD
Differential D31561

linux(4): Fixup wait4 handling pid equal 0 case.
AbandonedPublic
Actions

Authored by dchagin on Aug 16 2021, 3:47 PM.
Tags
None
Referenced Files
F157345438: D31561.id93831.diff
Wed, May 20, 12:13 PM
F157329708: D31561.id.diff
Wed, May 20, 9:27 AM
F157329055: D31561.id93757.diff
Wed, May 20, 9:19 AM
Unknown Object (File)
Sun, May 17, 6:43 AM
Unknown Object (File)
Wed, May 13, 9:44 PM
Unknown Object (File)
Wed, May 13, 9:44 PM
Unknown Object (File)
Wed, May 13, 9:44 PM
Unknown Object (File)
Wed, May 13, 9:35 PM
View All Files
Subscribers
emaste
imp
kib
markj

Details

Reviewers
None
Group Reviewers
Linux Emulation
Summary

Pid equal 0 meaning wait for any child process whose process group identificator
is equal to that of the calling process.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41073
Build 37962: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 16 2021, 3:47 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2021, 3:47 PM
dchagin requested review of this revision.Aug 16 2021, 3:47 PM
Harbormaster completed remote builds in B41065: Diff 93757.Aug 16 2021, 3:47 PM
dchagin added a reviewer: Linux Emulation.Aug 16 2021, 3:48 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
emaste added a subscriber: emaste.Aug 16 2021, 5:03 PM

Special handling for -1 also needed

emaste added inline comments.Aug 16 2021, 5:08 PM
sys/compat/linux/linux_misc.c
1082

this should be pg_id no?

dchagin added a comment.Aug 16 2021, 5:22 PM
In D31561#711580, @emaste wrote:

Special handling for -1 also needed

it handled by pid < 0, as pid == -1 before it

sys/compat/linux/linux_misc.c
1082

ah)) sure!

emaste added a comment.Aug 16 2021, 5:33 PM

ah, #define WAIT_ANY (-1) /* any process */

dchagin updated this revision to Diff 93771.Aug 16 2021, 5:56 PM

fixed

Harbormaster completed remote builds in B41073: Diff 93771.Aug 16 2021, 5:56 PM
dchagin added a parent revision: D31566: Split sys_getpgid on two counterparts..Aug 16 2021, 5:57 PM
dchagin marked an inline comment as done.
dchagin updated this revision to Diff 93831.Aug 17 2021, 5:37 PM

abandon kern_getpgid

Harbormaster completed remote builds in B41100: Diff 93831.Aug 17 2021, 5:37 PM
emaste added subscribers: kib, markj.Aug 17 2021, 8:36 PM

This is what I'd have expected and it LGTM, but I'd defer to @markj or @kib for confirmation

kib added a comment.Aug 17 2021, 9:38 PM

In my copy of the FreeBSD source tree, linux_common_wait() has the following prototype

static int
linux_common_wait(struct thread *td, int pid, int *statusp,
    int options, struct __wrusage *wrup)

So I am not sure what is this about.

dchagin edited parent revisions, added: D31552: linux(4): Consolidate wait* facility into linux_common_wait().; removed: D31566: Split sys_getpgid on two counterparts..Aug 23 2021, 4:23 PM
In D31561#712206, @kib wrote:

In my copy of the FreeBSD source tree, linux_common_wait() has the following prototype

static int
linux_common_wait(struct thread *td, int pid, int *statusp,
    int options, struct __wrusage *wrup)

So I am not sure what is this about.

ah, it depends on D31552

kib added a comment.Sep 5 2021, 12:36 AM

Do you mean that our native wait4(2) does not correctly handle pid == 0 case?

dchagin abandoned this revision.Mar 29 2022, 6:41 PM
In D31561#718208, @kib wrote:

Do you mean that our native wait4(2) does not correctly handle pid == 0 case?

hmm, no,
seems it's my fault in the https://reviews.freebsd.org/D31552, and should be fixed there

dchagin mentioned this in D31552: linux(4): Consolidate wait* facility into linux_common_wait()..Mar 29 2022, 8:47 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
7 lines

Diff 93771

View Options

sys/compat/linux/linux_misc.c

Loading...