Differential D31466

amd64: Fix output operand specs for the stmxcsr and vmread intrinsics
ClosedPublic
Actions

Authored by markj on Aug 8 2021, 9:47 PM.

Details

Reviewers

kib

Group Reviewers

bhyve

Commits

rGe54ae8258d64: amd64: Fix output operand specs for the stmxcsr and vmread intrinsics

Summary

This does not appear to affect code generation, at least with the
default toolchain.

Noticed because incorrect output specifications lead to false positives
from KMSAN, as the instrumentation uses them to update shadow state for
output operands.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 8 2021, 9:47 PM

Herald added a reviewer: bhyve. · View Herald TranscriptAug 8 2021, 9:47 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Aug 8 2021, 9:47 PM

Harbormaster completed remote builds in B40929: Diff 93420.Aug 8 2021, 9:47 PM

kib accepted this revision.Aug 8 2021, 9:52 PM

This revision is now accepted and ready to land.Aug 8 2021, 9:52 PM

Closed by commit rGe54ae8258d64: amd64: Fix output operand specs for the stmxcsr and vmread intrinsics (authored by markj). · Explain WhyAug 9 2021, 5:49 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe54ae8258d64: amd64: Fix output operand specs for the stmxcsr and vmread intrinsics.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

fpu.c

2 lines

vmm/

intel/

vmx_cpufunc.h

5 lines

Diff 93453

View Options

sys/amd64/amd64/fpu.c