Paths

Table of Contentst

Differential D31451

Simplify nhop operations in ip_output().
ClosedPublic
Actions

Authored by melifaro on Aug 7 2021, 11:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 9, 4:43 AM

	Unknown Object (File)
	Thu, May 9, 1:30 AM

	Unknown Object (File)
	Mon, May 6, 8:42 PM

	Unknown Object (File)
	Tue, Apr 30, 11:05 AM

	Unknown Object (File)
	Mon, Apr 29, 5:39 AM

	Unknown Object (File)
	Apr 9 2024, 5:20 AM

	Unknown Object (File)
	Apr 8 2024, 8:41 PM

	Unknown Object (File)
	Apr 1 2024, 1:05 AM

View All 37 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG10e097610309: Simplify nhop operations in ip_output().
rG9748eb742791: Simplify nhop operations in ip_output().

Summary

Consistently use nh instead of always dereferencing ro->ro_nh inside the if block.
Always use nexthop mtu, as it provides guarantee that mtu is accurate.
Pass nh pointer to rt_update_ro_flags() to allow upcoming uses of updating ro flags based on different nexthop.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Aug 7 2021, 11:24 AM

Herald added subscribers: ae, imp. · View Herald TranscriptAug 7 2021, 11:24 AM

melifaro requested review of this revision.Aug 7 2021, 11:24 AM

Harbormaster completed remote builds in B40915: Diff 93369.Aug 7 2021, 11:24 AM

melifaro edited the summary of this revision. (Show Details)Aug 7 2021, 11:25 AM

melifaro added a reviewer: network.

melifaro added a parent revision: D30398: Route IPv4 packets via IPv6 next-hops.

kp accepted this revision as: kp.Aug 7 2021, 9:32 PM

This revision is now accepted and ready to land.Aug 7 2021, 9:32 PM

Closed by commit rG9748eb742791: Simplify nhop operations in ip_output(). (authored by melifaro). · Explain WhyAug 8 2021, 9:21 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG9748eb742791: Simplify nhop operations in ip_output()..

melifaro added a commit: rG10e097610309: Simplify nhop operations in ip_output()..Sep 7 2021, 9:15 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

route/

21 lines

netinet/

27 lines

Diff 93400

sys/net/route/route_ctl.c

Loading...

sys/netinet/ip_output.c

Loading...