e1000: Fix lem/em UDP rx csum offload
ClosedPublic
Actions

Authored by kbowling on Aug 7 2021, 4:36 AM.

Details

Reviewers

emaste
scottl
grehan

Group Reviewers

Intel Networking

Commits

rGec56aaca91b2: e1000: Fix lem/em UDP rx csum offload
rG0d0726a769a1: e1000: Fix lem/em UDP rx csum offload
rG015075f38348: e1000: Fix lem/em UDP rx csum offload

Summary

Rebase on igb code and unify lem/em implementations.

PR: 257642
MFC after: 1 week

Test Plan

Checked lem vs em functionality by datasheet:

lem section 3.2.3.2: http://iommu.com/datasheets/e1000-datasheets/pcie-gbe-controllers-open-source-manual.pdf
em section 3.2.5.8: http://iommu.com/datasheets/e1000-datasheets/pci-pci-x-family-gbe-controllers-software-dev-manual.pdf

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling requested review of this revision.Aug 7 2021, 4:36 AM

kbowling created this revision.

kbowling retitled this revision from e1000: Fix UDP rx checksum offload to e1000: Fix lem/em UDP rx csum offload.Aug 7 2021, 4:38 AM

karels added a subscriber: karels.Aug 7 2021, 1:01 PM

karels added inline comments.

sys/dev/e1000/em_txrx.c
740	Isn't this test redundant?

kbowling updated this revision to Diff 93374.Aug 7 2021, 4:21 PM

kbowling marked an inline comment as done.

kbowling added inline comments.

sys/dev/e1000/em_txrx.c
740	Yes, thanks!

karels added inline comments.Aug 7 2021, 5:04 PM

sys/dev/e1000/em_txrx.c
740	fwiw, the comment might have been worth keeping.

emaste added inline comments.Aug 7 2021, 5:13 PM

sys/dev/e1000/em_txrx.c
740	Yeah, seems like it

kbowling marked an inline comment as done.Aug 7 2021, 5:49 PM

kbowling added a subscriber: grehan.

kbowling added inline comments.

sys/dev/e1000/em_txrx.c
740	I'm indifferent to it, I'd want to go add it back to igb and igc if it stays here. @grehan thoughts?

grehan accepted this revision.Aug 9 2021, 9:22 PM

This revision is now accepted and ready to land.Aug 9 2021, 9:22 PM

Closed by commit rG015075f38348: e1000: Fix lem/em UDP rx csum offload (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyAug 9 2021, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG015075f38348: e1000: Fix lem/em UDP rx csum offload.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG0d0726a769a1: e1000: Fix lem/em UDP rx csum offload.Aug 16 2021, 12:58 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGec56aaca91b2: e1000: Fix lem/em UDP rx csum offload.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

em_txrx.c

67 lines

Diff 93374

View Options

e1000: Fix lem/em UDP rx csum offloadClosedPublicActions