Details

Reviewers

None

Group Reviewers

Commits

rP399278: Drop the necessity to add ${PORTSDIR} to dependency line

Summary

Remove now uneeded extra ${PORTSDIR}/ in dependencies the recent changes in
dependency handling makes it possible to not add this extra MACRO

I have done minimal testing with portupgrade/portinstall

The only known failure is make_index I'm working on it

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 739
Build 739: arc lint + arc unit

Event Timeline

bapt updated this revision to Diff 9300.Oct 10 2015, 6:30 PM

bapt retitled this revision from to Remove now uneeded extra ${PORTSDIR}/ in dependencies.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added a reviewer: portmgr.

Herald edited edge metadata. · View Herald TranscriptOct 10 2015, 6:30 PM

make_index now happy

Herald edited edge metadata. · View Herald TranscriptOct 10 2015, 7:01 PM

Fix a typo

Herald edited edge metadata. · View Herald TranscriptOct 10 2015, 7:04 PM

I'm all for that, but won't it break portmaster or portupgrade ?

In D3866#80057, @mat wrote:

I'm all for that, but won't it break portmaster or portupgrade ?

As said in the summary I have tested both of them (installing stuff only) and it worked

antoine added a subscriber: antoine.Oct 12 2015, 8:57 PM

antoine added inline comments.

Mk/Uses/blaslapack.mk
27	This line looks wrong
Mk/Uses/pear.mk
79	This looks wrong
142	this looks wrong
Mk/Uses/python.mk
385	this looks wrong

Address Antoine's comments

Herald edited edge metadata. · View Herald TranscriptOct 13 2015, 12:24 PM

antoine added inline comments.Oct 13 2015, 12:33 PM

Mk/Uses/gnustep.mk
45	This one too, but it's commented out I will start exp run

koobs added a subscriber: koobs.Oct 13 2015, 1:17 PM

there is a problem during make index due to the change in Uses/python.mk

make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python27: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python27" returned non-zero status
make[6]: chdir lang/python34: No such file or directory
make[5]: "/usr/ports/Mk/Uses/python.mk" line 385: warning: "make -V PORTVERSION -C lang/python34" returned non-zero status

Readd a ${PORTSDIR} to please make index with python

Herald edited edge metadata. · View Herald TranscriptOct 13 2015, 1:26 PM

Closed by commit rP399278: Drop the necessity to add ${PORTSDIR} to dependency line (authored by bapt). · Explain WhyOct 14 2015, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Remove now uneeded extra ${PORTSDIR}/ in dependenciesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9304

Mk/Uses/ada.mk

Mk/Uses/autoreconf.mk

Mk/Uses/bison.mk

Mk/Uses/blaslapack.mk

Mk/Uses/cmake.mk

Mk/Uses/compiler.mk

Mk/Uses/cran.mk

Mk/Uses/desktop-file-utils.mk

Mk/Uses/display.mk

Mk/Uses/drupal.mk

Mk/Uses/elixir.mk

Mk/Uses/erlang.mk

Mk/Uses/execinfo.mk

Mk/Uses/fakeroot.mk

Mk/Uses/fam.mk

Mk/Uses/fmake.mk

Mk/Uses/fonts.mk

Mk/Uses/fortran.mk

Mk/Uses/fuse.mk

Mk/Uses/gecko.mk

Mk/Uses/gettext-runtime.mk

Mk/Uses/gettext-tools.mk

Mk/Uses/ghostscript.mk

Mk/Uses/gmake.mk

Mk/Uses/gnustep.mk

Mk/Uses/gperf.mk

Mk/Uses/gssapi.mk

Mk/Uses/horde.mk

Mk/Uses/iconv.mk

Mk/Uses/imake.mk

Mk/Uses/jpeg.mk

Mk/Uses/lha.mk

Mk/Uses/libarchive.mk

Mk/Uses/libedit.mk

Mk/Uses/libtool.mk

Mk/Uses/lua.mk

Mk/Uses/makeinfo.mk

Mk/Uses/makeself.mk

Mk/Uses/mono.mk

Mk/Uses/motif.mk

Mk/Uses/ncurses.mk

Mk/Uses/ninja.mk

Mk/Uses/objc.mk

Mk/Uses/openal.mk

Mk/Uses/pear.mk

Mk/Uses/perl5.mk

Mk/Uses/pgsql.mk

Mk/Uses/pkgconfig.mk

Mk/Uses/pure.mk

Mk/Uses/python.mk

Mk/Uses/qmail.mk

Mk/Uses/readline.mk

Mk/Uses/scons.mk

Mk/Uses/shared-mime-info.mk

Mk/Uses/tcl.mk

Mk/Uses/twisted.mk

Mk/Uses/xfce.mk

Mk/Uses/zip.mk

Mk/Uses/zope.mk

Mk/bsd.port.mk

Mk/bsd.qt.mk

Mk/bsd.ruby.mk

Mk/bsd.sdl.mk

Mk/bsd.tex.mk

Mk/bsd.wx.mk

Mk/bsd.xorg.mk

Remove now uneeded extra ${PORTSDIR}/ in dependencies
ClosedPublic
Actions

Revision Contents
Changeset List