pf: Remove unused arguments from pf_send_tcp()
ClosedPublic
Actions

Authored by kp on Jul 11 2021, 8:17 AM.

Tags

None

Referenced Files

	F175183483: D31136.id92303.diff
	Thu, Oct 8, 10:40 PM

	F175172972: D31136.id92065.diff
	Thu, Oct 8, 8:52 PM

	F175100687: D31136.diff
	Thu, Oct 8, 6:39 AM

	Unknown Object (File)
	Fri, Sep 11, 4:21 AM

	Unknown Object (File)
	Sep 6 2026, 6:41 PM

	Unknown Object (File)
	Sep 6 2026, 3:33 PM

	Unknown Object (File)
	Sep 5 2026, 12:41 PM

	Unknown Object (File)
	Sep 3 2026, 6:30 PM

Subscribers

Details

Reviewers

mjg

Group Reviewers

network

Commits

rG823c2bd77b6e: pf: Remove unused arguments from pf_send_tcp()
rG33222b6f8af8: pf: Remove unused arguments from pf_send_tcp()
rG295f2d939d96: pf: Remove unused arguments from pf_send_tcp()

Summary

struct mbuf *replyto is not actually used (and only rarely provided).
The same applies to struct ifnet *ifp.

No functional change.

MFC after: 1 week
Sponsored by: Modirum MDPay

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jul 11 2021, 8:17 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptJul 11 2021, 8:17 AM

kp requested review of this revision.Jul 11 2021, 8:17 AM

Harbormaster completed remote builds in B40432: Diff 92065.Jul 11 2021, 8:17 AM

mjg accepted this revision.Jul 11 2021, 7:29 PM

This revision is now accepted and ready to land.Jul 11 2021, 7:29 PM

Closed by commit rG295f2d939d96: pf: Remove unused arguments from pf_send_tcp() (authored by kp). · Explain WhyJul 17 2021, 2:00 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG295f2d939d96: pf: Remove unused arguments from pf_send_tcp().

kp added a commit: rG33222b6f8af8: pf: Remove unused arguments from pf_send_tcp().Jul 24 2021, 8:02 PM

kp added a commit: rG823c2bd77b6e: pf: Remove unused arguments from pf_send_tcp().

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

42 lines

Diff 92303

View Options

pf: Remove unused arguments from pf_send_tcp()ClosedPublicActions