pf: locally originating connections with 'route-to' fail
ClosedPublic
Actions

Authored by kp on Jul 14 2021, 12:39 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGe650ef36ba9e: pf: locally originating connections with 'route-to' fail
rG44c47bc6d61e: pf: locally originating connections with 'route-to' fail
rG2c0d115bbc8f: pf: locally originating connections with 'route-to' fail

Summary

Similar to the REPLY_TO shortcut (6d786845cf) we also can't shortcut
ROUTE_TO. If we do we will fail to apply transformations or update the
state, which can lead to premature termination of the connections.

PR: 257106
MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40468
Build 37357: arc lint + arc unit

Event Timeline

kp created this revision.Jul 14 2021, 12:39 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptJul 14 2021, 12:39 PM

kp requested review of this revision.Jul 14 2021, 12:39 PM

kp added a child revision: D31178: pf tests: test locally originated connections with route-to.

Harbormaster completed remote builds in B40468: Diff 92182.Jul 14 2021, 12:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 17 2021, 2:30 PM

Closed by commit rG2c0d115bbc8f: pf: locally originating connections with 'route-to' fail (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG2c0d115bbc8f: pf: locally originating connections with 'route-to' fail.

kp added a commit: rG44c47bc6d61e: pf: locally originating connections with 'route-to' fail.Aug 7 2021, 4:30 PM

kp added a commit: rGe650ef36ba9e: pf: locally originating connections with 'route-to' fail.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

6 lines

Diff 92182

View Options

pf: locally originating connections with 'route-to' failClosedPublicActions