Page MenuHomeFreeBSD
Differential D31064

xen/intr: arm64: implement xen_arch_intr_intrcnt_init()
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Jul 5 2021, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 22, 9:09 PM
Unknown Object (File)
Sun, Jun 22, 7:32 PM
Unknown Object (File)
Sat, Jun 21, 2:07 AM
Unknown Object (File)
Fri, Jun 20, 6:58 PM
Unknown Object (File)
Fri, Jun 20, 12:52 PM
Unknown Object (File)
Fri, Jun 20, 7:42 AM
Unknown Object (File)
Wed, Jun 11, 11:10 AM
Unknown Object (File)
Fri, Jun 6, 1:11 AM
View All 63 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
royger
mhorne
julien_xen.org
manu
Summary

Unfortunately this really looks like THE interrupt needs a full set of
IPI interrupt counters. For the moment, simply use a static throw-away
variable.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40322
Build 37211: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jul 5 2021, 6:41 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 5 2021, 6:41 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
ehem_freebsd_m5p.com requested review of this revision.Jul 5 2021, 6:41 PM
Harbormaster completed remote builds in B40322: Diff 91820.Jul 5 2021, 6:41 PM
ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jul 5 2021, 6:45 PM
ehem_freebsd_m5p.com added a parent revision: D31062: xen/intr: implement aarch64 variant of xen_arch_intr.c.
ehem_freebsd_m5p.com added a parent revision: D30937: xen/intr: add architecture interrupt counter initializer.Jul 5 2021, 6:50 PM
ehem_freebsd_m5p.com added a comment.Jul 5 2021, 7:02 PM

I'm really unsure what this should look like. The interrupt really should have per-core counters since it is expected to occur on all cores which process Xen events. Yet the intrng code only has a single per-interrupt counter, thus appearing to implicitly assume any given interrupt will only occur on one core which the interrupt has been assigned to.

ehem_freebsd_m5p.com mentioned this in D30937: xen/intr: add architecture interrupt counter initializer.Jul 5 2021, 10:37 PM
ehem_freebsd_m5p.com planned changes to this revision.Sep 3 2021, 1:58 AM
ehem_freebsd_m5p.com mentioned this in D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.

I expect to abandon as a better solution has shown up, I'm simply waiting for confirmation before doing so.

ehem_freebsd_m5p.com abandoned this revision.Sep 3 2021, 3:06 PM

Abandoning as a better approach was identified and has now passed the first testing round.

ehem_freebsd_m5p.com removed a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Sep 3 2021, 3:11 PM
ehem_freebsd_m5p.com removed parent revisions: D30937: xen/intr: add architecture interrupt counter initializer, D31062: xen/intr: implement aarch64 variant of xen_arch_intr.c.

Revision Contents
Changeset List

PathSize
sys/
arm64/
xen/
8 lines

Diff 91820

View Options

sys/arm64/xen/xen_arch_intr.c

Loading...