kqueue: add EV_KEEPUDATA flag
ClosedPublic
Actions

Authored by freebsdphab-AX9_cmx.ietfng.org on May 16 2021, 12:17 PM.

Details

Reviewers

jhb
domagoj.stolfa_gmail.com

Commits

rG0321a7990b27: kqueue: Add EV_KEEPUDATA flag

Summary

This allows us to, for example, NOTE_TRIGGER or EV_{EN,DIS}ABLE events without overwriting the stashed pointer.

Test Plan

Manual verification of EV_KEEPUDATA behavior, new test functions

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

freebsdphab-AX9_cmx.ietfng.org requested review of this revision.May 16 2021, 12:17 PM

freebsdphab-AX9_cmx.ietfng.org created this revision.

I've been using this locally and found it *extremely* useful, and frankly was quite surprised when I found out that EV_ENABLE/EV_DISABLE trashed udata originally.

freebsdphab-AX9_cmx.ietfng.org added a reviewer: jhb.Jun 1 2021, 12:50 PM

I think the only thing that would be nice to add in addition are some tests for this. Probably best for that to add a new "native" test binary in tests/sys/kqueue instead of shoe-horning this into the NetBSD tests.

freebsdphab-AX9_cmx.ietfng.org updated this revision to Diff 91229.Jun 22 2021, 7:20 PM

freebsdphab-AX9_cmx.ietfng.org edited the test plan for this revision. (Show Details)

freebsdphab-AX9_cmx.ietfng.org updated this revision to Diff 91266.Jun 23 2021, 2:19 PM

@jhb Any chance you could push this? I've been using this for months and it's worked well for me.

This revision is now accepted and ready to land.Sep 4 2021, 10:51 PM

Closed by commit rG0321a7990b27: kqueue: Add EV_KEEPUDATA flag (authored by nfilardo_microsoft.com, committed by jhb). · Explain WhySep 24 2021, 12:33 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0321a7990b27: kqueue: Add EV_KEEPUDATA flag.