Page MenuHomeFreeBSD

kqueue: add EV_KEEPUDATA flag
ClosedPublic

Authored by freebsdphab-AX9_cmx.ietfng.org on May 16 2021, 12:17 PM.
Tags
None
Referenced Files
F105582994: D30286.diff
Tue, Dec 17, 10:51 PM
Unknown Object (File)
Sun, Dec 8, 5:41 AM
Unknown Object (File)
Tue, Nov 26, 4:01 PM
Unknown Object (File)
Nov 12 2024, 4:14 AM
Unknown Object (File)
Nov 10 2024, 11:51 AM
Unknown Object (File)
Nov 5 2024, 4:33 PM
Unknown Object (File)
Oct 27 2024, 6:21 AM
Unknown Object (File)
Oct 26 2024, 11:41 PM

Details

Summary

This allows us to, for example, NOTE_TRIGGER or EV_{EN,DIS}ABLE events without overwriting the stashed pointer.

Test Plan

Manual verification of EV_KEEPUDATA behavior, new test functions

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I've been using this locally and found it *extremely* useful, and frankly was quite surprised when I found out that EV_ENABLE/EV_DISABLE trashed udata originally.

I think the only thing that would be nice to add in addition are some tests for this. Probably best for that to add a new "native" test binary in tests/sys/kqueue instead of shoe-horning this into the NetBSD tests.

@jhb Any chance you could push this? I've been using this for months and it's worked well for me.

This revision is now accepted and ready to land.Sep 4 2021, 10:51 PM
This revision was automatically updated to reflect the committed changes.