Page MenuHomeFreeBSD
Differential D30853

cam: add xpt_path_device to return device_t associated with a path
ClosedPublic
Actions

Authored by imp on Jun 21 2021, 7:01 PM.
Tags
None
Referenced Files
F157767331: D30853.id91468.diff
Sun, May 24, 11:40 PM
F157766659: D30853.id91468.diff
Sun, May 24, 11:31 PM
Unknown Object (File)
Tue, May 19, 10:28 AM
Unknown Object (File)
Tue, May 19, 10:21 AM
Unknown Object (File)
Mon, May 18, 12:13 PM
Unknown Object (File)
Mon, May 18, 12:06 PM
Unknown Object (File)
Mon, May 18, 8:14 AM
Unknown Object (File)
Fri, May 15, 3:48 AM
View All Files
Subscribers
None

Details

Reviewers
manu
kibab
ken
scottl
mav
Group Reviewers
cam
Commits
rG1ed401626792: cam: add xpt_path_sim_device to return device_t associated with a path
Summary

Return the device associated with the sim's bus when it called
xpt_bus_register, if any. Most real SIMs in the tree set this device,
but some virtual ones do not have a device_t assocaited with them.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40030
Build 36919: arc lint + arc unit

Event Timeline

imp created this revision.Jun 21 2021, 7:01 PM
Herald added a reviewer: cam. · View Herald TranscriptJun 21 2021, 7:01 PM
imp requested review of this revision.Jun 21 2021, 7:01 PM
Harbormaster completed remote builds in B40030: Diff 91187.Jun 21 2021, 7:01 PM
imp added reviewers: manu, kibab, ken, scottl, mav.Jun 21 2021, 7:02 PM
imp added a child revision: D30854: cam mmc: Assert that the xpt_bus_register registered a device_t.Jun 21 2021, 7:20 PM
imp added a parent revision: D30852: cam: Group all xpt_path*() functions together in cam_xpt.h.
mav accepted this revision.Jun 23 2021, 6:45 PM
This revision is now accepted and ready to land.Jun 23 2021, 6:45 PM
scottl accepted this revision.Jun 24 2021, 2:03 AM
mav added a comment.Jun 24 2021, 4:12 AM

I've just thought that struct cam_path has own device field. So the function name is confusing.

imp added a comment.Jun 28 2021, 9:58 PM
In D30853#694698, @mav wrote:

I've just thought that struct cam_path has own device field. So the function name is confusing.

I'll change to xpt_path_sim_device().

Closed by commit rG1ed401626792: cam: add xpt_path_sim_device to return device_t associated with a path (authored by imp). · Explain WhyJun 28 2021, 10:25 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG1ed401626792: cam: add xpt_path_sim_device to return device_t associated with a path.

Revision Contents
Changeset List

PathSize
sys/
cam/
1 line
16 lines

Diff 91187

View Options

sys/cam/cam_xpt.h

Loading...
View Options

sys/cam/cam_xpt.c

Loading...