Page MenuHomeFreeBSD
Differential D30581

libalias: Restructure - Use AliasRange instead of PORT_BASE
ClosedPublic
Actions

Authored by donner on May 31 2021, 4:41 PM.
Tags
None
Referenced Files
F174540123: D30581.id90194.diff
Sun, Oct 4, 1:04 AM
Unknown Object (File)
Fri, Oct 2, 11:52 AM
Unknown Object (File)
Fri, Oct 2, 10:00 AM
Unknown Object (File)
Thu, Oct 1, 11:46 PM
Unknown Object (File)
Wed, Sep 30, 5:37 PM
Unknown Object (File)
Wed, Sep 30, 5:37 PM
Unknown Object (File)
Wed, Sep 30, 5:37 PM
Unknown Object (File)
Wed, Sep 30, 4:51 PM
View All Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rG9efcad61d830: libalias: Restructure - Use AliasRange instead of PORT_BASE
Summary

Get rid of PORT_BASE.
Replace by AliasRange.
Simplify code.

Test Plan

Run testsuite.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39994
Build 36883: arc lint + arc unit

Event Timeline

donner created this revision.May 31 2021, 4:41 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 31 2021, 4:41 PM
donner requested review of this revision.May 31 2021, 4:41 PM
Harbormaster completed remote builds in B39604: Diff 90193.May 31 2021, 4:41 PM
donner updated this revision to Diff 90194.May 31 2021, 4:49 PM
  • Factor out the search for a new port. Improves the perfomance a bit.
  • Fix errornous cherry-picking bugs
Harbormaster completed remote builds in B39605: Diff 90194.May 31 2021, 4:49 PM
donner added a child revision: D30582: libalias: Restructure - Finalize.May 31 2021, 4:55 PM
donner added a reviewer: network.May 31 2021, 4:58 PM
donner updated this revision to Diff 90249.Jun 1 2021, 9:28 AM

Rebase

Harbormaster completed remote builds in B39633: Diff 90249.Jun 1 2021, 9:28 AM
donner updated this revision to Diff 90842.Jun 13 2021, 8:51 PM

Rebase

Harbormaster completed remote builds in B39891: Diff 90842.Jun 13 2021, 8:51 PM
donner updated this revision to Diff 91117.Jun 19 2021, 7:43 PM

Use arc4random_uniform(3) as recommended by Dimitry Luhtionov.

Harbormaster completed remote builds in B39994: Diff 91117.Jun 19 2021, 7:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2021, 7:53 PM
Closed by commit rG9efcad61d830: libalias: Restructure - Use AliasRange instead of PORT_BASE (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG9efcad61d830: libalias: Restructure - Use AliasRange instead of PORT_BASE.
donner mentioned this in rG78d515b2225e: libalias: Restructure.Jul 6 2021, 6:57 AM
donner mentioned this in rGe0a40dc22771: libalias: Restructure.Jul 6 2021, 7:12 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
171 lines

Diff 91117

View Options

sys/netinet/libalias/alias_db.c

Loading...