Page MenuHomeFreeBSD
Differential D30574

libalias: Restructure - Group incoming links
ClosedPublic
Actions

Authored by donner on May 31 2021, 3:24 PM.
Tags
None
Referenced Files
F112620355: D30574.diff
Thu, Mar 20, 3:07 PM
Unknown Object (File)
Wed, Mar 12, 6:01 PM
Unknown Object (File)
Wed, Feb 26, 9:55 AM
Unknown Object (File)
Mon, Feb 24, 12:26 PM
Unknown Object (File)
Mon, Feb 24, 11:04 AM
Unknown Object (File)
Feb 18 2025, 3:24 AM
Unknown Object (File)
Feb 17 2025, 12:13 PM
Unknown Object (File)
Feb 9 2025, 5:28 PM
View All Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rG492d3b7109b4: libalias: Restructure - Group incoming links
Summary

Reorder incoming links by grouping of common search terms.
Massive performance improvement for incoming (missing) flows.

Remove LSNAT from outgoing search.
Slight speedup due to less comparsions in the loop.

Depends on D30573

Test Plan

Run testsuite.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

donner created this revision.May 31 2021, 3:24 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 31 2021, 3:24 PM
donner requested review of this revision.May 31 2021, 3:24 PM
Harbormaster completed remote builds in B39595: Diff 90184.May 31 2021, 3:24 PM
donner added a reviewer: network.May 31 2021, 3:26 PM
donner added a child revision: D30575: libalias: Restructure - Group expire handling entries.May 31 2021, 4:09 PM
donner updated this revision to Diff 90186.May 31 2021, 4:15 PM
  • Rename (old) lnk variable to (new) grp.
Harbormaster completed remote builds in B39597: Diff 90186.May 31 2021, 4:15 PM
donner updated this revision to Diff 90202.May 31 2021, 7:21 PM

Rebase

Harbormaster completed remote builds in B39611: Diff 90202.May 31 2021, 7:21 PM
donner updated this revision to Diff 90246.Jun 1 2021, 9:27 AM

Rebase

Harbormaster completed remote builds in B39630: Diff 90246.Jun 1 2021, 9:27 AM
donner edited child revisions, added: D30582: libalias: Restructure - Finalize; removed: D30575: libalias: Restructure - Group expire handling entries.Jun 1 2021, 9:42 AM
donner removed a parent revision: D30573: libalias: Restructure - Cleanup and Use for links.Jun 1 2021, 9:47 AM
donner added a parent revision: D30571: libalias: Restructure - Cleanup _FindLinkIn.
donner updated this revision to Diff 90839.Jun 13 2021, 8:50 PM
donner added a parent revision: D30573: libalias: Restructure - Cleanup and Use for links.

Rebase

Harbormaster completed remote builds in B39888: Diff 90839.Jun 13 2021, 8:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2021, 7:08 PM
Closed by commit rG492d3b7109b4: libalias: Restructure - Group incoming links (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG492d3b7109b4: libalias: Restructure - Group incoming links.
donner mentioned this in rG78d515b2225e: libalias: Restructure.Jul 6 2021, 6:57 AM
donner mentioned this in rGe0a40dc22771: libalias: Restructure.Jul 6 2021, 7:12 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
218 lines
14 lines

Diff 91114

View Options

sys/netinet/libalias/alias_db.c

Show First 20 Lines • Show All 547 Lines • ▼ Show 20 Lines if (tarfs_str2int64(hdrp->mtime, sizeof(hdrp->mtime), &num) != 0) {
error = EINVAL; error = EINVAL;
goto bad; goto bad;
} }
mtime = num; mtime = num;
rdev = NODEV; rdev = NODEV;
TARFS_DPF(ALLOC, "%s: [%c] %zu @%jd %o %d:%d\n", __func__, TARFS_DPF(ALLOC, "%s: [%c] %zu @%jd %o %d:%d\n", __func__,
hdrp->typeflag[0], sz, (intmax_t)mtime, mode, uid, gid); hdrp->typeflag[0], sz, (intmax_t)mtime, mode, uid, gid);
/* extended header? */ /* global extended header? */
if (hdrp->typeflag[0] == TAR_TYPE_GLOBAL_EXTHDR) { if (hdrp->typeflag[0] == TAR_TYPE_GLOBAL_EXTHDR) {
printf("%s: unsupported global extended header at %zu\n", TARFS_DPF(ALLOC, "%s: %zu-byte global extended header at %zu\n",
__func__, (size_t)(TARFS_BLOCKSIZE * (blknum - 1))); __func__, sz, TARFS_BLOCKSIZE * (blknum - 1));
error = EFTYPE; goto skip;
goto bad;
} }
/* extended header? */
if (hdrp->typeflag[0] == TAR_TYPE_EXTHDR) { if (hdrp->typeflag[0] == TAR_TYPE_EXTHDR) {
if (exthdr != NULL) { if (exthdr != NULL) {
TARFS_DPF(IO, "%s: multiple extended headers at %zu\n", TARFS_DPF(IO, "%s: multiple extended headers at %zu\n",
__func__, TARFS_BLOCKSIZE * (blknum - 1)); __func__, TARFS_BLOCKSIZE * (blknum - 1));
error = EFTYPE; error = EFTYPE;
goto bad; goto bad;
} }
/* read the contents of the exthdr */ /* read the contents of the exthdr */
TARFS_DPF(ALLOC, "%s: %zu-byte extended header at %zd\n", TARFS_DPF(ALLOC, "%s: %zu-byte extended header at %zu\n",
__func__, sz, TARFS_BLOCKSIZE * (blknum - 1)); __func__, sz, TARFS_BLOCKSIZE * (blknum - 1));
exthdr = malloc(sz, M_TEMP, M_WAITOK); exthdr = malloc(sz, M_TEMP, M_WAITOK);
res = tarfs_io_read_buf(tmp, false, exthdr, res = tarfs_io_read_buf(tmp, false, exthdr,
TARFS_BLOCKSIZE * blknum, sz); TARFS_BLOCKSIZE * blknum, sz);
if (res < 0) { if (res < 0) {
error = -res; error = -res;
goto bad; goto bad;
} }
▲ Show 20 Lines • Show All 666 Lines • Show Last 20 Lines
View Options

sys/netinet/libalias/alias_local.h

Show First 20 Lines • Show All 547 Lines • ▼ Show 20 Lines if (tarfs_str2int64(hdrp->mtime, sizeof(hdrp->mtime), &num) != 0) {
error = EINVAL; error = EINVAL;
goto bad; goto bad;
} }
mtime = num; mtime = num;
rdev = NODEV; rdev = NODEV;
TARFS_DPF(ALLOC, "%s: [%c] %zu @%jd %o %d:%d\n", __func__, TARFS_DPF(ALLOC, "%s: [%c] %zu @%jd %o %d:%d\n", __func__,
hdrp->typeflag[0], sz, (intmax_t)mtime, mode, uid, gid); hdrp->typeflag[0], sz, (intmax_t)mtime, mode, uid, gid);
/* extended header? */ /* global extended header? */
if (hdrp->typeflag[0] == TAR_TYPE_GLOBAL_EXTHDR) { if (hdrp->typeflag[0] == TAR_TYPE_GLOBAL_EXTHDR) {
printf("%s: unsupported global extended header at %zu\n", TARFS_DPF(ALLOC, "%s: %zu-byte global extended header at %zu\n",
__func__, (size_t)(TARFS_BLOCKSIZE * (blknum - 1))); __func__, sz, TARFS_BLOCKSIZE * (blknum - 1));
error = EFTYPE; goto skip;
goto bad;
} }
/* extended header? */
if (hdrp->typeflag[0] == TAR_TYPE_EXTHDR) { if (hdrp->typeflag[0] == TAR_TYPE_EXTHDR) {
if (exthdr != NULL) { if (exthdr != NULL) {
TARFS_DPF(IO, "%s: multiple extended headers at %zu\n", TARFS_DPF(IO, "%s: multiple extended headers at %zu\n",
__func__, TARFS_BLOCKSIZE * (blknum - 1)); __func__, TARFS_BLOCKSIZE * (blknum - 1));
error = EFTYPE; error = EFTYPE;
goto bad; goto bad;
} }
/* read the contents of the exthdr */ /* read the contents of the exthdr */
TARFS_DPF(ALLOC, "%s: %zu-byte extended header at %zd\n", TARFS_DPF(ALLOC, "%s: %zu-byte extended header at %zu\n",
__func__, sz, TARFS_BLOCKSIZE * (blknum - 1)); __func__, sz, TARFS_BLOCKSIZE * (blknum - 1));
exthdr = malloc(sz, M_TEMP, M_WAITOK); exthdr = malloc(sz, M_TEMP, M_WAITOK);
res = tarfs_io_read_buf(tmp, false, exthdr, res = tarfs_io_read_buf(tmp, false, exthdr,
TARFS_BLOCKSIZE * blknum, sz); TARFS_BLOCKSIZE * blknum, sz);
if (res < 0) { if (res < 0) {
error = -res; error = -res;
goto bad; goto bad;
} }
▲ Show 20 Lines • Show All 666 Lines • Show Last 20 Lines