Codify our standard practice with $FreeBSD$
o New code only needs it if it might land in stable/12
o Old code should retain it until stable/12 is unsupported
o We'll do a bulk remove in the future: don't do it proactively.
Sponsored by: Netflix
Details
Details
- Reviewers
allanjude ceri - Group Reviewers
manpages - Commits
- rG5851680bcabe: style(9): Add advice about $FreeBSD$
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 39955 Build 36844: arc lint + arc unit
Event Timeline
Comment Actions
Wording tweak from bcr
Use .Li markup as used elsewhere for $FreeBSD$
Add ", if applicable" to an earlier mention of $FreeBSD$
Comment Actions
Tweaked a little.
A bit torn on whether to move the bulk of the wording changes up or not...
| share/man/man9/style.9 | ||
|---|---|---|
| 118–119 | Possibly as a separate commit: For non C/C++ language source files, if applicable, add | |
Comment Actions
take up allanjude's suggestion, with a tweak or two (sorry allan,
I did this before I saw your review :)
| share/man/man9/style.9 | ||
|---|---|---|
| 119–124 | This is a little unclear. Do C/C++ source files need to follow the same rules about including/not including $FreeBSD$? If so, why is this highlighted text where it is? | |
| share/man/man9/style.9 | ||
|---|---|---|
| 119–124 | I did a reorder to mention both cases, which should clear things up. | |