Page MenuHomeFreeBSD
Differential D30604

libalias: Restructure - Remove temporary state deleteAllLinks from global struct
ClosedPublic
Actions

Authored by donner on Jun 1 2021, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 27, 8:14 PM
Unknown Object (File)
Wed, May 27, 7:57 PM
Unknown Object (File)
Wed, May 27, 8:33 AM
Unknown Object (File)
Wed, May 27, 7:26 AM
Unknown Object (File)
Tue, May 26, 5:26 AM
Unknown Object (File)
Wed, May 20, 11:31 PM
Unknown Object (File)
Tue, May 19, 8:30 AM
Unknown Object (File)
Mon, May 18, 9:47 PM
View All Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rGfe83900f9fa9: libalias: Restructure - Remove temporary state deleteAllLinks from global struct
Summary

The entry deleteAllLinks in the struct libalias is only used to signal
a state between internal calls. It's not used between API calls.

Test Plan

Use testsuite.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39899
Build 36788: arc lint + arc unit

Event Timeline

donner created this revision.Jun 1 2021, 6:31 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptJun 1 2021, 6:31 PM
donner requested review of this revision.Jun 1 2021, 6:31 PM
donner added a child revision: D30582: libalias: Restructure - Finalize.Jun 1 2021, 6:32 PM
Harbormaster completed remote builds in B39652: Diff 90282.Jun 1 2021, 6:32 PM
donner added a reviewer: network.Jun 1 2021, 6:32 PM
donner updated this revision to Diff 90843.Jun 13 2021, 8:51 PM

rebase

Harbormaster completed remote builds in B39892: Diff 90843.Jun 13 2021, 8:51 PM
donner updated this revision to Diff 90850.Jun 13 2021, 9:22 PM
  • Remove an unnecessary local var
Harbormaster completed remote builds in B39899: Diff 90850.Jun 13 2021, 9:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2021, 7:58 PM
Closed by commit rGfe83900f9fa9: libalias: Restructure - Remove temporary state deleteAllLinks from global struct (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rGfe83900f9fa9: libalias: Restructure - Remove temporary state deleteAllLinks from global struct.
donner mentioned this in rG78d515b2225e: libalias: Restructure.Jul 6 2021, 6:57 AM
donner mentioned this in rGe0a40dc22771: libalias: Restructure.Jul 6 2021, 7:12 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
58 lines
3 lines

Diff 90850

View Options

sys/netinet/libalias/alias_db.c

Loading...
View Options

sys/netinet/libalias/alias_local.h

Loading...