linuxkpi: Define XA_FLAGS_ALLOC1 in linux/xarray.h
Needs ReviewPublic
Actions

Authored by nc on Jun 12 2021, 5:32 PM.

Details

Reviewers

bz
• hselasky
manu

Summary

This is needed by the drm-kmod 5.7 update

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39867
Build 36756: arc lint + arc unit

Event Timeline

nc created this revision.Jun 12 2021, 5:32 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJun 12 2021, 5:32 PM

nc requested review of this revision.Jun 12 2021, 5:32 PM

Harbormaster completed remote builds in B39867: Diff 90802.Jun 12 2021, 5:32 PM

What does this new flag do? Should it be (1U << 2) perhaps?

In D30747#691142, @hselasky wrote:

What does this new flag do? Should it be (1U << 2) perhaps?

See:

https://www.kernel.org/doc/html/v5.5/core-api/xarray.html#allocating-xarrays
https://www.kernel.org/doc/html/v5.5/core-api/xarray.html#c.DEFINE_XARRAY_ALLOC1

I chose (1U << 1) mainly for compatibility with Linux, but it could also be (1U << 2).

See: https://github.com/openbsd/src/search?q=XA_FLAGS_ALLOC1

How is this needed ? We don't use xarray in drm gem yet.

OK.

This flag must be "1U << 2" in FreeBSD, and you must implement it in the xarray code like they do on Linux, by reserving index 0 from allocation.

--HPS

Use (1U << 2) as per @hselasky's request.

Harbormaster completed remote builds in B39879: Diff 90828.Jun 13 2021, 8:24 PM

Like said, this is a feature, so you need to implement this in the xarray C-code too. It is not enough just to define this flag!

I think this can be abandoned now?

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

xarray.h

1 line

Diff 90802

View Options

sys/compat/linuxkpi/common/include/linux/xarray.h

linuxkpi: Define XA_FLAGS_ALLOC1 in linux/xarray.hNeeds ReviewPublicActions