Page MenuHomeFreeBSD

linuxkpi: Define XA_FLAGS_ALLOC1 in linux/xarray.h
Needs ReviewPublic

Authored by nc on Jun 12 2021, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 4:59 PM
Unknown Object (File)
Tue, Apr 2, 12:24 AM
Unknown Object (File)
Feb 6 2024, 3:04 AM
Unknown Object (File)
Dec 25 2023, 8:30 PM
Unknown Object (File)
Nov 29 2023, 12:47 PM
Unknown Object (File)
Oct 13 2023, 11:52 AM
Unknown Object (File)
Oct 12 2023, 12:18 AM
Unknown Object (File)
Sep 14 2023, 9:26 AM

Details

Summary

This is needed by the drm-kmod 5.7 update

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39879
Build 36768: arc lint + arc unit

Event Timeline

nc requested review of this revision.Jun 12 2021, 5:32 PM

What does this new flag do? Should it be (1U << 2) perhaps?

I chose (1U << 1) mainly for compatibility with Linux, but it could also be (1U << 2).

See: https://github.com/openbsd/src/search?q=XA_FLAGS_ALLOC1

How is this needed ? We don't use xarray in drm gem yet.

OK.

This flag must be "1U << 2" in FreeBSD, and you must implement it in the xarray code like they do on Linux, by reserving index 0 from allocation.

--HPS

Use (1U << 2) as per @hselasky's request.

Like said, this is a feature, so you need to implement this in the xarray C-code too. It is not enough just to define this flag!

I think this can be abandoned now?