Page MenuHomeFreeBSD
Differential D30708

linuxkpi: Add list_for_each_entry_lockless() macro
ClosedPublic
Actions

Authored by nc on Jun 9 2021, 6:21 PM.
Tags
None
Referenced Files
F153598313: D30708.id90704.diff
Wed, Apr 22, 5:52 AM
F153556965: D30708.id90704.diff
Tue, Apr 21, 9:28 PM
F153529054: D30708.id90704.diff
Tue, Apr 21, 4:32 PM
F153513074: D30708.id90674.diff
Tue, Apr 21, 1:45 PM
Unknown Object (File)
Tue, Apr 21, 2:41 AM
Unknown Object (File)
Tue, Apr 21, 2:40 AM
Unknown Object (File)
Mon, Apr 20, 10:13 AM
Unknown Object (File)
Mon, Apr 20, 1:30 AM
View All Files
Subscribers
bz
emaste
• hselasky
imp
manu
linuxkpi

Details

Reviewers
bz
• hselasky
manu
Group Reviewers
linuxkpi
Commits
rG210349325af9: linuxkpi: Add list_for_each_entry_lockless() macro
rGb47f461c8e67: linuxkpi: Add list_for_each_entry_lockless() macro
Summary

The reason why list_for_each_entry() is being redefined here is because unlike the Linux version, FreeBSD's list_for_each_entry() does not use locks.

This is needed by the drm-kmod 5.7 update.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39827
Build 36716: arc lint + arc unit

Event Timeline

nc created this revision.Jun 9 2021, 6:21 PM
Herald added a subscriber: emaste. · View Herald TranscriptJun 9 2021, 6:21 PM
nc requested review of this revision.Jun 9 2021, 6:21 PM
nc retitled this revision from Add list_for_each_entry_lockless() macro to linuxkpi: Add list_for_each_entry_lockless() macro.Jun 9 2021, 6:23 PM
manu added a comment.Jun 9 2021, 6:35 PM

If it's the same as list_for_each_entry you should explain why in the commit message.

nc edited the summary of this revision. (Show Details)Jun 9 2021, 7:10 PM

I believe linuxkpi's list_for_each_entry is lockless (but am not sure), so I updated the message.

• hselasky added a comment.Jun 9 2021, 8:37 PM

Please use function macro.

#define list_for_each_entry_lockless(...) list_for_each_entry(__VA_ARGS__)

--HPS

nc updated this revision to Diff 90674.Jun 9 2021, 11:07 PM

Using function macro as per @hselasky's suggestion.

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2021, 11:07 PM
Harbormaster completed remote builds in B39827: Diff 90674.Jun 9 2021, 11:08 PM
• hselasky accepted this revision.Jun 10 2021, 7:29 AM
This revision is now accepted and ready to land.Jun 10 2021, 7:29 AM
Closed by commit rGb47f461c8e67: linuxkpi: Add list_for_each_entry_lockless() macro (authored by nc). · Explain WhyJun 10 2021, 3:16 PM
This revision was automatically updated to reflect the committed changes.
nc added a commit: rGb47f461c8e67: linuxkpi: Add list_for_each_entry_lockless() macro.
nc added a commit: rG210349325af9: linuxkpi: Add list_for_each_entry_lockless() macro.Jun 14 2021, 7:06 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
2 lines

Diff 90674

View Options

sys/compat/linuxkpi/common/include/linux/list.h

Loading...