Page MenuHomeFreeBSD
Differential D30705

linuxkpi: Add pm_qos.h
AbandonedPublic
Actions

Authored by nc on Jun 9 2021, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 19 2024, 2:05 PM
Unknown Object (File)
Dec 20 2023, 2:57 AM
Unknown Object (File)
Oct 5 2023, 4:32 AM
Unknown Object (File)
Jul 22 2023, 6:52 AM
Subscribers
bz
emaste
• hselasky
manu
linuxkpi

Details

Reviewers
bz
• hselasky
manu
Group Reviewers
linuxkpi
Summary

This is needed by the drm-kmod 5.7 update.

Imported from: OpenBSD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc created this revision.Jun 9 2021, 6:18 PM
Herald added a subscriber: emaste. · View Herald TranscriptJun 9 2021, 6:18 PM
nc requested review of this revision.Jun 9 2021, 6:18 PM
manu added inline comments.Jun 9 2021, 6:33 PM
sys/compat/linuxkpi/common/include/linux/pm_qos.h
6

This is not correct.
The file in OpenBSD is public domain.
Also no modification to it was done by you so you can't add your copyright.

nc updated this revision to Diff 90656.Jun 9 2021, 7:07 PM

Use original OpenBSD file with headers.

• hselasky added inline comments.Jun 9 2021, 8:31 PM
sys/compat/linuxkpi/common/include/linux/pm_qos.h
11

Is there a missing do {} while (0) for each of these defines?

manu requested changes to this revision.Jul 22 2021, 4:34 PM

I would rather have some patches drm-kmod as it's the only user.
I don't see the point of having it in the tree if it's just dummy function.
I'd prefer to just #ifdef linux the drm code until we implement those properly (if ever).

This revision now requires changes to proceed.Jul 22 2021, 4:34 PM
nc abandoned this revision.Jul 22 2021, 8:54 PM
In D30705#704410, @manu wrote:

I would rather have some patches drm-kmod as it's the only user.
I don't see the point of having it in the tree if it's just dummy function.
I'd prefer to just #ifdef linux the drm code until we implement those properly (if ever).

Thanks for the feedback, @manu.

This is a relic of my 5.7-wip branch which was shelved for 5.6-wip, the latter of which doesn't need this patch.

However, I do like your idea of using #ifdefs for the time being.

I'll abandon this for now.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
19 lines

Diff 90656

View Options

sys/compat/linuxkpi/common/include/linux/pm_qos.h

Loading...