Page MenuHomeFreeBSD

linuxkpi: Add pm_qos.h
AbandonedPublic

Authored by nc on Jun 9 2021, 6:18 PM.

Details

Reviewers
bz
hselasky
manu
Group Reviewers
linuxkpi
Summary

This is needed by the drm-kmod 5.7 update.

Imported from: OpenBSD

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

nc requested review of this revision.Jun 9 2021, 6:18 PM
sys/compat/linuxkpi/common/include/linux/pm_qos.h
5

This is not correct.
The file in OpenBSD is public domain.
Also no modification to it was done by you so you can't add your copyright.

Use original OpenBSD file with headers.

sys/compat/linuxkpi/common/include/linux/pm_qos.h
11

Is there a missing do {} while (0) for each of these defines?

manu requested changes to this revision.Jul 22 2021, 4:34 PM

I would rather have some patches drm-kmod as it's the only user.
I don't see the point of having it in the tree if it's just dummy function.
I'd prefer to just #ifdef linux the drm code until we implement those properly (if ever).

This revision now requires changes to proceed.Jul 22 2021, 4:34 PM
In D30705#704410, @manu wrote:

I would rather have some patches drm-kmod as it's the only user.
I don't see the point of having it in the tree if it's just dummy function.
I'd prefer to just #ifdef linux the drm code until we implement those properly (if ever).

Thanks for the feedback, @manu.

This is a relic of my 5.7-wip branch which was shelved for 5.6-wip, the latter of which doesn't need this patch.

However, I do like your idea of using #ifdefs for the time being.

I'll abandon this for now.