Page MenuHomeFreeBSD
Differential D30671

tests/netgraph: Attribute errors to the caller
ClosedPublic
Actions

Authored by donner on Jun 7 2021, 2:03 PM.
Tags
None
Referenced Files
F84697806: D30671.id.diff
Mon, May 27, 8:14 AM
F84697289: D30671.diff
Mon, May 27, 8:02 AM
Unknown Object (File)
Tue, May 14, 2:54 AM
Unknown Object (File)
Mon, May 13, 10:50 AM
Unknown Object (File)
Mon, May 13, 10:50 AM
Unknown Object (File)
Mon, May 13, 8:42 AM
Unknown Object (File)
Mon, May 13, 8:27 AM
Unknown Object (File)
Feb 11 2024, 8:43 PM
View All 41 Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
kp
Group Reviewers
network
tests
Commits
rG9021c46603bf: tests/netgraph: Attribute errors to the caller
Summary

Errors raised in the common util functions should raise the location
of their caller to be useful and include the errno description.

Depends on D30629

Test Plan

Before

failed: .../util.c:151: -1 != NgSendData(ds, hook, data, len) not met

After

failed: .../basic.c:55: -1 != NgSendData(ds, hook, data, len) not met (No route to host)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

donner created this revision.Jun 7 2021, 2:03 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptJun 7 2021, 2:03 PM
donner requested review of this revision.Jun 7 2021, 2:03 PM
Harbormaster completed remote builds in B39766: Diff 90519.Jun 7 2021, 2:03 PM
donner added reviewers: network, tests.Jun 7 2021, 2:04 PM
donner added a child revision: D30692: tests/netgraph: Fix style.Jun 8 2021, 8:55 AM
kp accepted this revision as: kp.Jun 8 2021, 4:00 PM
This revision is now accepted and ready to land.Jun 8 2021, 4:00 PM
Closed by commit rG9021c46603bf: tests/netgraph: Attribute errors to the caller (authored by donner). · Explain WhyJun 8 2021, 5:25 PM
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG9021c46603bf: tests/netgraph: Attribute errors to the caller.
donner mentioned this in rG36c7408818c5: tests/netgraph: Inital framework for testing libnetgraph.Jun 15 2021, 12:40 PM
donner mentioned this in rG2def89063412: tests/netgraph: Inital framework for testing libnetgraph.Jun 16 2021, 11:46 AM
donner mentioned this in rG4a0c1d0543af: tests/netgraph: Inital framework for testing libnetgraph.Jun 16 2021, 11:50 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
netgraph/
48 lines
43 lines

Diff 90597

View Options

tests/sys/netgraph/util.h

Loading...
View Options

tests/sys/netgraph/util.c

Loading...