Page MenuHomeFreeBSD

pf: Fix more ioctl memory leaks
ClosedPublic

Authored by kp on Jun 1 2021, 2:20 PM.
Tags
None
Referenced Files
F82940275: D30595.id.diff
Sat, May 4, 6:42 AM
Unknown Object (File)
Wed, May 1, 1:47 AM
Unknown Object (File)
Sat, Apr 27, 5:19 PM
Unknown Object (File)
Mar 7 2024, 11:40 PM
Unknown Object (File)
Feb 21 2024, 7:09 AM
Unknown Object (File)
Dec 29 2023, 9:36 PM
Unknown Object (File)
Dec 23 2023, 12:25 AM
Unknown Object (File)
Dec 17 2023, 10:01 AM

Details

Summary

We must also remember to free nvlists added to a parent nvlist with
nvlist_append_nvlist_array().

More importantly, when nvlist_pack() allocates memory for us it does so
in the M_NVLIST zone, so we must free it with free(.., M_NVLIST). Using
free(.., M_TEMP) as we did silently failed to free the memory.

MFC after: 3 days
Repored by: kib@
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39639
Build 36528: arc lint + arc unit