Page MenuHomeFreeBSD

pf: Fix more ioctl memory leaks
ClosedPublic

Authored by kp on Jun 1 2021, 2:20 PM.
Tags
None
Referenced Files
F137969426: D30595.id90258.diff
Thu, Nov 27, 6:47 PM
Unknown Object (File)
Thu, Nov 27, 12:31 PM
Unknown Object (File)
Sun, Nov 23, 4:17 AM
Unknown Object (File)
Tue, Nov 18, 8:46 PM
Unknown Object (File)
Sun, Nov 9, 6:33 AM
Unknown Object (File)
Sun, Nov 9, 6:30 AM
Unknown Object (File)
Thu, Oct 30, 11:19 AM
Unknown Object (File)
Thu, Oct 30, 9:51 AM

Details

Summary

We must also remember to free nvlists added to a parent nvlist with
nvlist_append_nvlist_array().

More importantly, when nvlist_pack() allocates memory for us it does so
in the M_NVLIST zone, so we must free it with free(.., M_NVLIST). Using
free(.., M_TEMP) as we did silently failed to free the memory.

MFC after: 3 days
Repored by: kib@
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable