Page MenuHomeFreeBSD

pf: Fix more ioctl memory leaks
ClosedPublic

Authored by kp on Jun 1 2021, 2:20 PM.
Tags
None
Referenced Files
F104207120: D30595.diff
Wed, Dec 4, 6:27 PM
F104194984: D30595.id90258.diff
Wed, Dec 4, 2:31 PM
F104194980: D30595.id.diff
Wed, Dec 4, 2:31 PM
F104194916: D30595.id90285.diff
Wed, Dec 4, 2:31 PM
F104193813: D30595.diff
Wed, Dec 4, 2:10 PM
Unknown Object (File)
Fri, Nov 8, 5:39 AM
Unknown Object (File)
Fri, Nov 8, 4:05 AM
Unknown Object (File)
Oct 17 2024, 8:13 PM

Details

Summary

We must also remember to free nvlists added to a parent nvlist with
nvlist_append_nvlist_array().

More importantly, when nvlist_pack() allocates memory for us it does so
in the M_NVLIST zone, so we must free it with free(.., M_NVLIST). Using
free(.., M_TEMP) as we did silently failed to free the memory.

MFC after: 3 days
Repored by: kib@
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39639
Build 36528: arc lint + arc unit