Page MenuHomeFreeBSD
Differential D30570

libalias: Restructure - Table for partial links
ClosedPublic
Actions

Authored by donner on May 31 2021, 2:25 PM.
Tags
None
Referenced Files
F140097676: D30570.id90835.diff
Sat, Dec 20, 4:54 AM
F140084342: D30570.id90242.diff
Sat, Dec 20, 12:51 AM
F140083475: D30570.id90242.diff
Sat, Dec 20, 12:35 AM
Unknown Object (File)
Thu, Dec 18, 11:07 PM
Unknown Object (File)
Thu, Dec 18, 10:56 PM
Unknown Object (File)
Thu, Dec 18, 9:50 PM
Unknown Object (File)
Thu, Dec 18, 6:43 PM
Unknown Object (File)
Wed, Dec 17, 6:55 PM
View All Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rGcac129e60300: libalias: Restructure - Table for partially links
Summary

Separate the partially specified links into a separate data structure.

This would causes a major parformance impact, if there are many of
them. Use a (smaller) hash table to speed up the partially link
access.

Test Plan

Use testsuite.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39589
Build 36478: arc lint + arc unit

Event Timeline

donner created this revision.May 31 2021, 2:25 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 31 2021, 2:25 PM
donner requested review of this revision.May 31 2021, 2:25 PM
Harbormaster completed remote builds in B39587: Diff 90172.May 31 2021, 2:25 PM
donner added a parent revision: D30569: libalias: Restructure - Separate fully qualified search.May 31 2021, 2:25 PM
donner added a reviewer: network.
donner added a child revision: D30571: libalias: Restructure - Cleanup _FindLinkIn.May 31 2021, 2:28 PM
donner updated this revision to Diff 90174.May 31 2021, 2:46 PM
  • Cleanup the partial find procedure
Harbormaster completed remote builds in B39589: Diff 90174.May 31 2021, 2:46 PM
donner updated this revision to Diff 90201.May 31 2021, 7:15 PM
  • Just another early exit of the search loop
Harbormaster completed remote builds in B39610: Diff 90201.May 31 2021, 7:15 PM
donner updated this revision to Diff 90242.Jun 1 2021, 9:25 AM

Rebase

Harbormaster completed remote builds in B39626: Diff 90242.Jun 1 2021, 9:26 AM
donner retitled this revision from libalias: Restructure - Table for partially links to libalias: Restructure - Table for partial links.Jun 1 2021, 10:07 AM
donner updated this revision to Diff 90835.Jun 13 2021, 8:49 PM

rebase

Harbormaster completed remote builds in B39884: Diff 90835.Jun 13 2021, 8:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2021, 6:06 PM
Closed by commit rGcac129e60300: libalias: Restructure - Table for partially links (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rGcac129e60300: libalias: Restructure - Table for partially links.
donner mentioned this in rG78d515b2225e: libalias: Restructure.Jul 6 2021, 6:57 AM
donner mentioned this in rGe0a40dc22771: libalias: Restructure.Jul 6 2021, 7:12 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
74 lines
2 lines

Diff 90174

View Options

sys/netinet/libalias/alias_db.c

Loading...
View Options

sys/netinet/libalias/alias_local.h

Loading...