libpmc: eliminate pmc_pmu_stat_mode()
ClosedPublic
Actions

Authored by mhorne on May 28 2021, 6:10 PM.

Details

Reviewers

emaste
ray
gnn

Group Reviewers

pmc

Commits

rGb040b03d32c3: libpmc: eliminate pmc_pmu_stat_mode()
rGec66cc955b62: libpmc: eliminate pmc_pmu_stat_mode()

Summary

There is a single consumer, the pmc utility, that clearly has knowledge
of which counters it is expecting. Remove this function and have it
use common counter aliases instead.

No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39543
Build 36432: arc lint + arc unit

Event Timeline

mhorne created this revision.May 28 2021, 6:10 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 28 2021, 6:10 PM

mhorne requested review of this revision.May 28 2021, 6:10 PM

Harbormaster completed remote builds in B39543: Diff 90066.May 28 2021, 6:10 PM

mhorne edited the summary of this revision. (Show Details)May 28 2021, 6:26 PM

mhorne added inline comments.

usr.sbin/pmc/cmd_pmc_stat.c
114	Since it is not obvious from the diff, these aliases refer to the same counters as the names being removed above (on intel at least). Therefore, later calls to `pmc_allocate()` in this file will behave the same.